Send prompt=select_account on browser login - #57
Open
aberoham wants to merge 1 commit into
Open
Conversation
The authorization URL had no prompt parameter, so a browser with an existing Microsoft session was signed in silently. That made it impossible to sign a second account into another profile through the default browser flow; only device code offered an account picker. The URL construction moves into build_authorize_url with tests covering the existing parameters and the new prompt. Fixes osodevops#52. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NXWLJ9g87M3GtLSACr2gmi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52.
The authorization URL for the browser (auth code + PKCE) flow had no
promptparameter, so a browser with an existing Microsoft session was signed in silently. That made it impossible to sign a second account into another profile through the default flow —teams --profile alt auth loginstored a token for the already-signed-in user. Only device code offered an account picker.The URL now includes
prompt=select_account, matching common multi-account CLI behavior. Cost is one extra click per login for single-account users; logins are rare.URL construction moves into
build_authorize_urlwith tests covering the existing parameters and the new prompt.cargo fmt,cargo clippy --all-targets -- -D warnings, andcargo test --binspass (134 tests).🤖 Generated with Claude Code
https://claude.ai/code/session_01NXWLJ9g87M3GtLSACr2gmi