Conversation
mbuechse
force-pushed
the
issue/1262
branch
from
September 15, 2026 09:50
48a92d0 to
8e0643c
Compare
ideaship
requested changes
Sep 15, 2026
ideaship
left a comment
ideaship
left a comment
Contributor
There was a problem hiding this comment.
Can you squash the second commit into the first? There is no need for a separate Blackify commit.
Collaborator
Author
|
@ideaship yup, sure, I usually do squash and merge, but I can squash right away |
This is the minimal change to address #1262 Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
mbuechse
force-pushed
the
issue/1262
branch
from
September 15, 2026 12:42
8e0643c to
5ce23e1
Compare
Contributor
|
If you want to have your change merged, you need to undraft it. Otherwise we don't know if you consider it ready. |
Collaborator
Author
|
There is a minor detail that I want to clarify before I can remove the draft state. At this point, it would mainly be good to know whether the general direction works for you, so that the final review (when I remove the draft state) can be done swiftly. |
Contributor
|
The general direction works for me. There is some work needed on top of that, but I don't want to expose you to scope creep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the minimal change to address #1262