Repository navigation
Sort directory listings in inpainting and super-resolution converters - #4056
Merged
sstrehlk merged 4 commits intoOct 8, 2026
Merged
Conversation
sstrehlk
approved these changes
Sep 11, 2026
pwolnows
enabled auto-merge (squash)
October 7, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes annotation conversion deterministic for the
InpaintingConverterandSRConverterby sorting directory listings before use.Changes
inpainting.py: sortimagesandmasksfile lists fromiterdir()before pairing them up.super_resolution_converter.py: sortlr_dir.iterdir()results before building the low-resolution file list.Why
Path.iterdir()order is filesystem-dependent and not guaranteed, which can cause images/masks (or LR files) to be paired inconsistently across OSes/runs. Sorting the listings ensures reproducible annotation ordering.Testing