Skip to content

migrate bing streetside to typescript - #12778

Open
k-yle wants to merge 1 commit into
developfrom
kh/ts-streetside3
Open

k-yle wants to merge 1 commit into
developfrom
kh/ts-streetside3

Conversation

@k-yle

@k-yle k-yle commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

there's a few runtime changes in this PR, but they're all self explanatory

@k-yle k-yle added this to the typescript migration milestone Aug 24, 2026
@k-yle k-yle added the chore Improvements to the iD development experience or codebase label Aug 24, 2026
.replace('{subdomain}', bubble.imageUrlSubdomains[0]),
ca: bubble.he || bubble.heading,
captured_at: bubble.vintageEnd,
captured_at: bubble.vintageEnd ? new Date(bubble.vintageEnd) : undefined,

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is technically a bug fix, but it the bug isn't noticable, because both String and Date have a .toLocaleString() method

This branch was successfully deployed

1 active deployment
pr-preview-12778 — b0e5aa77 Deployed Sep 8, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Improvements to the iD development experience or codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant