Conversation
k-yle
force-pushed
the
kh/core-history
branch
from
September 8, 2026 11:00
8c6d032 to
ec75242
Compare
k-yle
force-pushed
the
kh/core-history
branch
from
September 8, 2026 11:06
ec75242 to
fdf715b
Compare
k-yle
force-pushed
the
kh/core-history
branch
from
September 8, 2026 11:18
fdf715b to
1603800
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is huge, because I tried @tyrasd's approach from #12601: converting it to TypeScript and to an ES6 class at the same time
most of the changes are just adding
this.*as a prefix to all local variables