ci: re-enable tls-scanner for RHOAI e2e, scope to redhat-ods-applications

[ugiordan]

Restores tls-scanner-run to the opendatahub-operator-rhoai-e2e job (reverted in #82675 due to blocking PRs before 3.5 GA code freeze).

Root cause of the original failure:

The redhat-ods-operator namespace contains rhods-operator-catalog — an OLM file-based catalog server created by operator-sdk run bundle, serving plain-text gRPC on port 50051. This is intentional CI infrastructure, not a compliance target.

Fix:

• Scan all four RHOAI-owned namespaces: redhat-ods-operator, redhat-ods-applications, redhat-ods-monitoring, rhoai-model-registries
• Add a cleanup-olm-catalog step before the scanner that deletes the CatalogSource and waits for the catalog pod to terminate — so we scan the operator manager pod without hitting the catalog pod false positive
• tls-scanner-run is added back as the last test: step, matching the original Add tls-scanner-run to RHOAI e2e job #82555 structure (same cluster, blocking, enforced)

/cc @GowthamShanmugam @davidebianchi

[coderabbitai]

Walkthrough

The CI configuration adds the tls-scanner-tool image and enables TLS scanning for the RHOAI E2E workflow with PQC and namespace settings.

Changes

RHOAI TLS scanner integration

Layer / File(s)	Summary
TLS scanner image declaration ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml	The configuration adds the OpenShift 4.22 tls-scanner-tool base image.
RHOAI E2E scanner workflow ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml	The RHOAI E2E test sets PQC_CHECK=true and SCAN_NAMESPACE=redhat-ods-applications, then runs tls-scanner-run as a post-step.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• openshift/release#82154: Adds the TLS scanner image and configures TLS scanner execution.
• openshift/release#82216: Adds scanner settings and the tls-scanner-run post-step to E2E configuration.
• openshift/release#83172: Configures RHOAI E2E TLS scanning with PQC and namespace settings.

Suggested reviewers: davidebianchi

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Container-Privileges	❌ Error	The added tls-scanner-run ref activates a generated Pod with hostNetwork:true, hostPID:true, privileged:true, and runAsUser:0 in tls-scanner-run-commands.sh.	Remove the privileged scanner activation or change the scanner Pod to restricted security settings without hostNetwork, hostPID, or privileged mode.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only CI YAML and adds static environment keys and the tls-scanner-run ref; it adds no Ginkgo It, Describe, Context, or When test titles.
Test Structure And Quality	✅ Passed	The PR modifies only one CI YAML file and adds no Ginkgo test code or It blocks; the Ginkgo quality requirements are not applicable.
Microshift Test Compatibility	✅ Passed	The PR changes only CI YAML configuration; it adds no Ginkgo tests or test references to MicroShift-unavailable APIs or features.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only CI YAML; it adds no Ginkgo tests or test-source changes, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only CI configuration: a base image, scanner environment variables, and a post-step; it adds no deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only one CI YAML file; added lines configure an image, environment variables, and a step, with no OTE binary or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit changes only CI YAML; it adds no Ginkgo tests, IPv4 literals, URL construction, or public-network access. tls-scanner-run scans the cluster namespace.
No-Weak-Crypto	✅ Passed	The PR only adds CI YAML for the TLS scanner, PQC_CHECK, and namespace scope; the added lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto code, or secret comparisons.
No-Sensitive-Data-In-Logs	✅ Passed	The patch adds only image, scanner settings, and a step reference; it adds no credentials, PII, customer data, or logging code, and narrows the scan namespace.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main changes: re-enabling the TLS scanner for RHOAI E2E tests and scoping it to the target namespace.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@ugiordan: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-opendatahub-io-opendatahub-operator-main-images	opendatahub-io/opendatahub-operator	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-opendatahub-operator-main-opendatahub-operator-e2e	opendatahub-io/opendatahub-operator	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-opendatahub-operator-main-opendatahub-operator-rhoai-e2e	opendatahub-io/opendatahub-operator	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[davidebianchi]

/pj-rehearse

[openshift-merge-bot]

@davidebianchi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[ugiordan]

/pj-rehearse ack

[openshift-merge-bot]

@ugiordan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidebianchi, ugiordan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/opendatahub-io/opendatahub-operator/OWNERS [davidebianchi,ugiordan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@ugiordan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.