CNTRLPLANE-3237: pull https://github.com/openshift/library-go/pull/2430

[p0lyn0mial]

Summary by CodeRabbit

• Chores
  • Updated an internal library dependency to a newer revision, incorporating upstream improvements and fixes.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@p0lyn0mial: This pull request references CNTRLPLANE-3237 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6ee0c211-1d2c-41be-aca1-c3c6baad25d6

📥 Commits

Reviewing files that changed from the base of the PR and between 37bb076 and cf3c2ba.

⛔ Files ignored due to path filters (4)

• go.sum is excluded by !**/*.sum
• vendor/github.com/openshift/library-go/pkg/operator/condition/condition.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/library-go/test/library/encryption/preflight_deploy.go is excluded by !**/vendor/**, !vendor/**
• vendor/modules.txt is excluded by !**/vendor/**, !vendor/**

📒 Files selected for processing (1)

• go.mod

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.

---

Walkthrough

The pull request updates the github.com/openshift/library-go dependency in go.mod from revision afd94040089b to 3034bdc74c7d.

Changes

Library Go dependency update

Layer / File(s)	Summary
Update library-go revision go.mod	The module requirement now references the newer pseudo-version and commit revision.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to cf3c2

The change updates a vendored library dependency, with no actionable merge-blocking risk remaining beyond normal owner confirmation of the intended upstream revision and release controls.

Suggested reviewers: ardaguclu, bertinatto, gangwgr

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title identifies the Jira issue and the specific library-go pull request used for the dependency update.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes dependency metadata and vendored library code only; no *_test.go file or Ginkgo It/Describe/Context/When/Specify title call is added or modified.
Test Structure And Quality	✅ Passed	The PR changes only vendored library-go helpers and a socket constant; changed test files use testing.TB, not Ginkgo DSL, and their wait.Poll calls remain time-bounded.
Microshift Test Compatibility	✅ Passed	The PR diff adds no files, Ginkgo declarations, or new e2e tests. It only updates library-go metadata and vendored implementation/helpers, so this check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The patch adds no Ginkgo e2e tests. It changes dependency metadata and vendored library-go code; added Go lines contain no It, Describe, Context, When, or SNO-sensitive topology assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR only updates library-go metadata and vendored KMS/condition/test code; the diff adds no affinity, topology spread, node targeting, tolerations, replicas, or PDB scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only library-go vendoring; the OTE main already calls klog.LogToStderr(true), and changed code adds no process-level stdout writes or initializers that emit output.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR only bumps library-go and vendors KMS/helper changes; the diff adds no Ginkgo e2e declarations, IPv4 assumptions, or external connectivity.
No-Weak-Crypto	✅ Passed	The dependency diff adds KMS socket/status plumbing only; added Go lines contain no weak algorithms, crypto constructors, or secret/token equality, and crypto subtrees are unchanged.
Container-Privileges	✅ Passed	The commit changes dependency metadata and vendored Go/tests only; no added privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings. Existing hostNetwork te...
No-Sensitive-Data-In-Logs	✅ Passed	The diff adds logs for validated local Unix socket paths and transient API errors; it does not log passwords, tokens, keys, PII, customer data, or hostnames.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[ardaguclu]

/lgtm
/approve

[openshift-merge-bot]

Scheduling required tests:
/test e2e-agnostic
/test e2e-agnostic-upgrade
/test e2e-console-login
/test e2e-gcp-operator-disruptive
/test e2e-oidc
/test e2e-operator

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-operator-encryption-kms
/test e2e-aws-operator-encryption-kms-2
/test e2e-gcp-operator-encryption-perf
/test e2e-gcp-operator-encryption-rotation
/test e2e-operator-encryption

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ardaguclu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[p0lyn0mial]

/hold

for the kms tests

[openshift-ci]

@p0lyn0mial: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-operator-encryption-kms-2	37bb076	link	false	/test e2e-aws-operator-encryption-kms-2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ardaguclu]

/lgtm

[openshift-merge-bot]

Scheduling required tests:
/test e2e-agnostic
/test e2e-agnostic-upgrade
/test e2e-console-login
/test e2e-gcp-operator-disruptive
/test e2e-oidc
/test e2e-operator

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-operator-encryption-kms
/test e2e-aws-operator-encryption-kms-2
/test e2e-gcp-operator-encryption-perf
/test e2e-gcp-operator-encryption-rotation
/test e2e-operator-encryption

[p0lyn0mial]

/retest

[p0lyn0mial]

/hold cancel
/verified by CI

[openshift-ci-robot]

@p0lyn0mial: This PR has been marked as verified by CI.

Details

In response to this:

/hold cancel
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.