WIP: OCPBUGS-65896: Update library-go to align Progressing condition

[tchap]

Blocked by openshift/library-go#2203

Summary by CodeRabbit

• Chores
  • Updated OpenShift module dependencies to latest versions.
  • Modified test fixtures to reflect updated status message terminology and formatting.

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

Updated Go module dependencies for three OpenShift modules and added a replace directive for an external fork of openshift/library-go. Test fixture expected outputs are refreshed with updated message terminology ("generation" to "revision") and CSR payloads to match new behavior.

Changes

Dependency and Test Fixture Refresh

Layer / File(s)	Summary
Dependency Updates go.mod	Three OpenShift modules (api, build-machinery-go, client-go) are updated to newer pseudo-versions. A replace directive adds openshift/library-go fork pointing to github.com/tchap/library-go v0.0.0-20260506134100-b32dd275556c.
Test Fixture Updates test-data/apply-configuration/overall/minimal-cluster/expected-output/.../authentications/*, test-data/apply-configuration/overall/oauth-apiserver-creation-minimal/expected-output/.../authentications/*, test-data/apply-configuration/overall/oauth-server-creation-minimal/expected-output/.../authentications/*	Status messages updated from "latest generation" to "latest revision" in Authentication resources; YAML scalar representations for message fields are normalized (block scalars converted to quoted or plain strings).
Additional Test Fixture Updates test-data/apply-configuration/overall/minimal-cluster/expected-output/.../certificatesigningrequests/2eee-body-system-COLON-openshift-COLON-openshift-authenticator-.yaml	CertificateSigningRequest spec.request base64 payload is refreshed to match new expected output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 9 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Single Node Openshift (Sno) Test Compatibility	⚠️ Warning	New Ginkgo e2e tests added (8 total across 2 files) lack SNO compatibility protection. Tests verify pod-to-pod network connectivity without required safeguards.	Add [Skipped:SingleReplicaTopology] label to test names or guard with exutil.IsSingleNode() check. Run SNO CI job: periodic-ci-openshift-release-master-ci-4.22-e2e-aws-upgrade-ovn-single-node
Ipv6 And Disconnected Network Test Compatibility	⚠️ Warning	Two new Ginkgo e2e tests pull from external public registries: keycloak.go (quay.io) and gitlab.go (docker.io). Tests lack [Skipped:Disconnected] annotation for disconnected environments.	Add [Skipped:Disconnected] to test names. Tests should be '[OIDC][Serial][Skipped:Disconnected] TestKeycloakAsOIDCPasswordGrantCheckAndGroupSync' and '[OIDC][Serial][Skipped:Disconnected] TestGitLabAsOIDCPasswordGrantCheck'
Microshift Test Compatibility	❓ Inconclusive	No result was produced after verification. Marking as INCONCLUSIVE.	Re-run the check or adjust instructions to produce a final result.

✅ Passed checks (9 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title mentions updating library-go to align the Progressing condition, which is partially related to the changeset. However, the main changes involve updating multiple OpenShift dependency modules in go.mod and updating test data YAML files. The title focuses on only one aspect (library-go and Progressing condition) rather than the broader scope of dependency updates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All 14 Ginkgo test names in the PR are stable and deterministic. No test titles contain dynamic information, generated identifiers, timestamps, or non-deterministic values. All follow best practices.
Test Structure And Quality	✅ Passed	Repository contains no Ginkgo tests—all 42 test files use standard Go testing (testing.T). The check for Ginkgo test code quality is not applicable since there are no Ginkgo tests in the codebase.
Topology-Aware Scheduling Compatibility	✅ Passed	PR updates library-go dependency and test data only. No new deployment manifests or scheduling constraints introduced. Existing constraints are topology-aware.
Ote Binary Stdout Contract	✅ Passed	No OTE Binary Stdout violations. PR only updates dependencies and test data. No source code changes to binaries. Existing fmt.Printf is in test blocks, exempt from check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@tchap: This pull request references Jira Issue OCPBUGS-65896, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (ksiddiqu@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Blocked by openshift/library-go#2203

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gangwgr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@tchap: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-operator-encryption-serial-ote-2of2	0f9e544	link	false	/test e2e-aws-operator-encryption-serial-ote-2of2
ci/prow/e2e-aws-operator-encryption-kms-serial-ote-2of2	0f9e544	link	false	/test e2e-aws-operator-encryption-kms-serial-ote-2of2
ci/prow/e2e-aws-operator-encryption-perf-serial-ote-2of2	0f9e544	link	false	/test e2e-aws-operator-encryption-perf-serial-ote-2of2
ci/prow/e2e-aws-operator-encryption-kms-serial-ote-1of2	0f9e544	link	false	/test e2e-aws-operator-encryption-kms-serial-ote-1of2
ci/prow/e2e-aws-operator-parallel-ote	0f9e544	link	false	/test e2e-aws-operator-parallel-ote
ci/prow/e2e-aws-operator-serial-ote	0f9e544	link	false	/test e2e-aws-operator-serial-ote
ci/prow/e2e-aws-operator-encryption-rotation-serial-ote-1of2	0f9e544	link	false	/test e2e-aws-operator-encryption-rotation-serial-ote-1of2
ci/prow/e2e-aws-operator-encryption-rotation-serial-ote-2of2	0f9e544	link	false	/test e2e-aws-operator-encryption-rotation-serial-ote-2of2
ci/prow/e2e-aws-operator-encryption-serial-ote-1of2	0f9e544	link	false	/test e2e-aws-operator-encryption-serial-ote-1of2
ci/prow/e2e-aws-operator-encryption-perf-serial-ote-1of2	0f9e544	link	false	/test e2e-aws-operator-encryption-perf-serial-ote-1of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.