Skip to content

fix: improve test coverage, remove scope guards#149

Merged
stee-re merged 1 commit into
openscd:mainfrom
danyill:issue-148-remove-ied-coverage
Jul 13, 2026
Merged

fix: improve test coverage, remove scope guards#149
stee-re merged 1 commit into
openscd:mainfrom
danyill:issue-148-remove-ied-coverage

Conversation

@danyill

@danyill danyill commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Some small simplifications:

  • Remove describe.only to run test suite and then fix treatment of Private elements.
  • Remove scope test. We can assume our SCL file is valid and it's not testable.
  • Remove nullish array coalescing, we never need this for these cases.
  • Remove Private check, we never need this because we have already filtered out Private elements.

I'm just getting back to scl-lib after a hiatus so I'm not intending to be especially pedantic, so sorry if this is a bit annoying 😿

These changes bring our test coverage for removeIED.ts up to 💯%

@danyill danyill requested a review from stee-re July 12, 2026 10:09
@danyill danyill changed the title fix: improve test coverage, remove scope guards. fix: improve test coverage, remove scope guards Jul 12, 2026
@stee-re

stee-re commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Wow! When I scanned over the changes, I thought to myself - no way - this is impossible!! But every single thing you found in removeIED was 100% spot on!! Thank you for making all of this better. I'm still embarressed that I let a "describe.only" get committed!!

@stee-re stee-re left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all these improvements - REALLY appriciated!!!

@stee-re stee-re merged commit 183fd77 into openscd:main Jul 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants