fix: improve test coverage, remove scope guards#149
Merged
Conversation
Collaborator
|
Wow! When I scanned over the changes, I thought to myself - no way - this is impossible!! But every single thing you found in removeIED was 100% spot on!! Thank you for making all of this better. I'm still embarressed that I let a "describe.only" get committed!! |
stee-re
approved these changes
Jul 13, 2026
stee-re
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for all these improvements - REALLY appriciated!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small simplifications:
describe.onlyto run test suite and then fix treatment ofPrivateelements.Privatecheck, we never need this because we have already filtered outPrivateelements.I'm just getting back to scl-lib after a hiatus so I'm not intending to be especially pedantic, so sorry if this is a bit annoying 😿
These changes bring our test coverage for
removeIED.tsup to 💯%