Fix controller FSM's XIF commit tracking signals (#610) - #611
Open
michael-platzer wants to merge 1 commit into
Open
michael-platzer wants to merge 1 commit into
michael-platzer wants to merge 1 commit into
Conversation
Ensure that the controller FSM's XIF commit transaction tracking signals are reset every time a new instruction enters the EX stage (now ensured by simply resetting these signals anytime the EX stage is ready). Fixes openhwfoundation#610. Signed-off-by: Michael Platzer <michael.platzer@hotmail.com>
Silabs-ArjanB
self-requested a review
July 21, 2022 12:32
Contributor
|
@michael-platzer Thank you for reporting the issue and fixing it at the same time. I do however not yet understand the failure scenario itself, see my question in #610 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the controller FSM's XIF commit transaction tracking
signals are reset every time a new instruction enters the EX stage
(now ensured by simply resetting these signals anytime the EX stage is
ready). Fixes #610.