Skip to content

fix: Squash agreement migrations removing broken data migration - #39276

Open
xitij2000 wants to merge 1 commit into
openedx:masterfrom
open-craft:kshitij/fix-migrations
Open

xitij2000 wants to merge 1 commit into
openedx:masterfrom
open-craft:kshitij/fix-migrations

Conversation

@xitij2000

Copy link
Copy Markdown
Contributor

Migration 0008 added with the User Agreements API PR in f0f725f contained
a RunPython migration that was created to migrate data from the format used in
the original version of the PR to a new version of the PR that was approved and
merged. This data migration was broken.

If any instance was using the old data format, this migration would fail since
it had major logical errors. Fortunately, the only situation it would run in is
if someone explicitly ran an instance with a commit pointing to the old data
structure. Since that was never in any release, not even in the master branch
this migration isn't needed my anyone and can be removed.

This commit squashes migrations and removes the data migration entirely, so no
existing or new instances should be affected.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 22, 2026
@openedx-webhooks

openedx-webhooks commented Oct 22, 2026 •

Copy link
Copy Markdown

Thanks for the pull request, @xitij2000!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform-oncall.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Migration 0008 added with the User Agreements API PR in f0f725f contained
a RunPython migration that was created to migrate data from the format used in
the original version of the PR to a new version of the PR that was approved and
merged. This data migration was broken.

If any instance was using the old data format, this migration would fail since
it had major logical errors. Fortunately, the only situation it would run in is
if someone explicitly ran an instance with a commit pointing to the old data
structure. Since that was never in any release, not even in the master branch
this migration isn't needed my anyone and can be removed.

This commit squashes migrations and removes the data migration entirely, so no
existing or new  instances should be affected.
@xitij2000
xitij2000 force-pushed the kshitij/fix-migrations branch from 0153ca6 to b5487b3 Compare October 22, 2026 14:18
@xitij2000
xitij2000 marked this pull request as ready for review October 22, 2026 14:18
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Oct 22, 2026
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Oct 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). needs reviewer assigned PR needs to be (re-)assigned a new reviewer open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

3 participants