Skip to content

feat(progress): allow customizing completion percentage precision - #2053

Open
Agrendalath wants to merge 1 commit into
openedx:masterfrom
open-craft:agrendalath/configurable-completion-precision
Open

feat(progress): allow customizing completion percentage precision#2053
Agrendalath wants to merge 1 commit into
openedx:masterfrom
open-craft:agrendalath/configurable-completion-precision

Conversation

@Agrendalath

@Agrendalath Agrendalath commented Sep 2, 2026

Copy link
Copy Markdown
Member

The completion donut chart on the progress tab always rounds its percentages to whole numbers. In courses with a large number of units, a learner can complete several units in a row without the chart moving at all, which is confusing.

This PR adds a COMPLETION_PERCENTAGE_PRECISION environment variable that controls how many decimal places the chart's percentages are rounded to. It defaults to 0, so it is fully backward -compatible.

Testing instructions

  1. Set the COMPLETION_PERCENTAGE_PRECISION in the MFE envs (e.g., via the MFE_CONFIG) and visit the course progress page.

Deadline

"None"

Other information

Private-ref: BB-11198

TODO: The only missing thing is the product proposal.

It can be adjusted with the  `COMPLETION_PERCENTAGE_PRECISION`  config.
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Sep 2, 2026
@openedx-webhooks

openedx-webhooks commented Sep 2, 2026

Copy link
Copy Markdown

Thanks for the pull request, @Agrendalath!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.60%. Comparing base (dcc62ac) to head (3d7ee61).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2053      +/-   ##
==========================================
+ Coverage   93.58%   93.60%   +0.01%     
==========================================
  Files         367      367              
  Lines        6004     6007       +3     
  Branches     1416     1417       +1     
==========================================
+ Hits         5619     5623       +4     
+ Misses        368      367       -1     
  Partials       17       17              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Agrendalath
Agrendalath marked this pull request as ready for review September 3, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants