Skip to content

fix: build with uv instead of pip in the uv-run PSR step - #436

Merged
bmtcril merged 1 commit into
openedx:masterfrom
irfanuddinahmad:irfanuddinahmad/fix-psr-build-needs-pip
Aug 27, 2026
Merged

fix: build with uv instead of pip in the uv-run PSR step#436
bmtcril merged 1 commit into
openedx:masterfrom
irfanuddinahmad:irfanuddinahmad/fix-psr-build-needs-pip

Conversation

@irfanuddinahmad

@irfanuddinahmad irfanuddinahmad commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

#435's uv-based workaround got past the GitPython crash (confirmed: this run correctly computed "The next version is: 4.1.1!") but hit a new failure at the build step: https://github.com/openedx/event-tracking/actions/runs/33071634441

PSR's build_command (pyproject.toml) shells out to python -m pip install --upgrade build, but uv's ephemeral venvs deliberately don't bundle pip the way a stdlib venv/virtualenv does.

Verified locally through the full real uvx-wrapped PSR execution, not just uv build standalone: produces the correct dist/*.tar.gz/*.whl artifacts.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Aug 27, 2026
@openedx-webhooks

openedx-webhooks commented Aug 27, 2026

Copy link
Copy Markdown

Thanks for the pull request, @irfanuddinahmad!

This repository is currently maintained by @openedx/committers-events.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Aug 27, 2026
@irfanuddinahmad
fix: build with uv instead of pip in the uv-run PSR step
66b85c8 
openedx#435's uv-based workaround got past the GitPython crash (confirmed: correctly computed "The next version is: 4.1.1!") but hit a new failure at the build step: PSR's build_command shelled out to 'python -m pip install --upgrade build', and uv's ephemeral venvs deliberately don't bundle pip the way a stdlib venv does.

Rather than add pip back in (which would undercut the point of this whole pip->uv migration), switch build_command itself to 'uv build' -- no pip anywhere. Verified locally through the full real uvx-wrapped PSR execution (not just uv build standalone): produces the correct dist/ artifacts with no pip involved at any point.
@irfanuddinahmad
irfanuddinahmad force-pushed the irfanuddinahmad/fix-psr-build-needs-pip branch from 09c9a25 to 66b85c8 Compare August 27, 2026 12:30
@irfanuddinahmad irfanuddinahmad changed the title fix: give the uv-run PSR build step access to pip fix: build with uv instead of pip in the uv-run PSR step Aug 27, 2026
@irfanuddinahmad irfanuddinahmad mentioned this pull request Aug 27, 2026
Closed
@bmtcril
bmtcril merged commit da5b485 into openedx:master Aug 27, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Aug 27, 2026
@irfanuddinahmad irfanuddinahmad mentioned this pull request Aug 31, 2026
Merged
2 tasks
bmtcril pushed a commit that referenced this pull request Aug 31, 2026
@irfanuddinahmad @claude
fix: revert PSR gitpython workaround now that upstream is fixed
5678c66 
python-semantic-release/python-semantic-release#1477 (merged 2026-08-28,
released in v10.6.2) fixes the GitPython 3.1.60 break that #435/#436
worked around. Reverts both back to using the official Docker action
(bumped v10.6.1 -> v10.6.2) and its pip-based build_command, since the
Docker image doesn't have uv available.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Aug 31, 2026
Closed
Merged
bmtcril pushed a commit that referenced this pull request Sep 2, 2026
@irfanuddinahmad @claude
fix: pin release.yml action refs to SHAs and match sample-plugin conf…
44590f5 
…ormance

release.yml (added in #425, touched again in #434/#435/#436/#438) had
drifted from the org's gold-standard reference (sample-plugin's
release.yml): python-semantic-release, actions/upload-artifact and
actions/download-artifact were on floating version tags (@v10.6.2, @v7,
@v8) instead of pinned commit SHAs, defeating the whole point of the
pin-actions-to-sha effort (this repo's own #407) for the one workflow
that runs unreviewed on every push to master.

Also:
- Drop `fetch-depth: 0` from the release job's checkout: python-semantic-
  release auto-deepens a shallow clone itself before evaluating version
  history, so it's never needed here (confirmed against sample-plugin).
- Add `if-no-files-found: error` to the dist upload step so a build that
  silently produces no artifacts fails loudly instead of shipping an
  empty release.
- Add the `github.ref_name == 'master'` guard to publish_to_pypi's `if:`,
  matching sample-plugin, even though this workflow currently only
  triggers on push to master.

All three added SHAs were independently verified against the upstream
repos via `gh api repos/<owner>/<repo>/commits/<sha>` and cross-checked
against their claimed tags (resolving through the annotated tag object
for python-semantic-release@v10.6.2, which points at commit
9a026e9303981c866c3425723009becb2437c757).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmtcril bmtcril bmtcril approved these changes

Assignees

No one assigned

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@irfanuddinahmad @openedx-webhooks @bmtcril