Skip to content

Add checks to enforce plan ID in featureprofiles - #6262

Open
RishabhAgarwal-2001 wants to merge 1 commit into
mainfrom
rishabh/enforce-plan-id-format
Open

RishabhAgarwal-2001 wants to merge 1 commit into
mainfrom
rishabh/enforce-plan-id-format

Conversation

@RishabhAgarwal-2001

Copy link
Copy Markdown
Contributor

No description provided.

@OpenConfigBot

OpenConfigBot commented Nov 9, 2026 •

Copy link
Copy Markdown

Pull Request Functional Test Report for #6262 / a855e6a

Virtual Devices

Device Test Status Test Documentation Job Raw Log
Arista cEOS status
status
status
status
Authz-1.0: failure
Certz-6: failure
Hashing-1.0: failure
bootz-1.0: failure
Authz-1.0: General Authz (1-4) tests
Certz-6: gNSI Client Certificate Baseline Test
Hashing-1.0: Dataplane Hashing with Physical Loopbacks
bootz-1.0: General bootz bootstrap tests
a10b5656 Log
Cisco 8000E status
status
status
status
Authz-1.0: failure
Certz-6: failure
Hashing-1.0: failure
bootz-1.0: failure
Authz-1.0: General Authz (1-4) tests
Certz-6: gNSI Client Certificate Baseline Test
Hashing-1.0: Dataplane Hashing with Physical Loopbacks
bootz-1.0: General bootz bootstrap tests
baf086d3 Log
Cisco XRd status
status
status
status
Authz-1.0: failure
Certz-6: failure
Hashing-1.0: failure
bootz-1.0: failure
Authz-1.0: General Authz (1-4) tests
Certz-6: gNSI Client Certificate Baseline Test
Hashing-1.0: Dataplane Hashing with Physical Loopbacks
bootz-1.0: General bootz bootstrap tests
2a04ef93 Log
Juniper ncPTX status
status
status
status
Authz-1.0: failure
Certz-6: failure
Hashing-1.0: failure
bootz-1.0: failure
Authz-1.0: General Authz (1-4) tests
Certz-6: gNSI Client Certificate Baseline Test
Hashing-1.0: Dataplane Hashing with Physical Loopbacks
bootz-1.0: General bootz bootstrap tests
a8bc9e6f Log
Nokia SR Linux status
status
status
status
Authz-1.0: failure
Certz-6: failure
Hashing-1.0: failure
bootz-1.0: failure
Authz-1.0: General Authz (1-4) tests
Certz-6: gNSI Client Certificate Baseline Test
Hashing-1.0: Dataplane Hashing with Physical Loopbacks
bootz-1.0: General bootz bootstrap tests
7f40b8b4 Log
Openconfig Lemming status
status
status
status
Authz-1.0: failure
Certz-6: failure
Hashing-1.0: failure
bootz-1.0: failure
Authz-1.0: General Authz (1-4) tests
Certz-6: gNSI Client Certificate Baseline Test
Hashing-1.0: Dataplane Hashing with Physical Loopbacks
bootz-1.0: General bootz bootstrap tests
07e7cbb6 Log

Hardware Devices

Device Test Status Test Documentation Raw Log
Arista status
status
status
status
Authz-1.0: pending authorization
Certz-6: pending authorization
Hashing-1.0: pending authorization
bootz-1.0: pending authorization
Authz-1.0: General Authz (1-4) tests
Certz-6: gNSI Client Certificate Baseline Test
Hashing-1.0: Dataplane Hashing with Physical Loopbacks
bootz-1.0: General bootz bootstrap tests
Cisco status
status
status
status
Authz-1.0: pending authorization
Certz-6: pending authorization
Hashing-1.0: pending authorization
bootz-1.0: pending authorization
Authz-1.0: General Authz (1-4) tests
Certz-6: gNSI Client Certificate Baseline Test
Hashing-1.0: Dataplane Hashing with Physical Loopbacks
bootz-1.0: General bootz bootstrap tests
Juniper status
status
status
status
Authz-1.0: pending authorization
Certz-6: pending authorization
Hashing-1.0: pending authorization
bootz-1.0: pending authorization
Authz-1.0: General Authz (1-4) tests
Certz-6: gNSI Client Certificate Baseline Test
Hashing-1.0: Dataplane Hashing with Physical Loopbacks
bootz-1.0: General bootz bootstrap tests
Nokia status
status
status
status
Authz-1.0: pending authorization
Certz-6: pending authorization
Hashing-1.0: pending authorization
bootz-1.0: pending authorization
Authz-1.0: General Authz (1-4) tests
Certz-6: gNSI Client Certificate Baseline Test
Hashing-1.0: Dataplane Hashing with Physical Loopbacks
bootz-1.0: General bootz bootstrap tests

Help

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements stricter validation for test plan IDs across the repository. By introducing a regex check in the synchronization tool, it ensures that all future and existing test plans adhere to a consistent versioned naming scheme. Several existing test definitions were updated to align with this new requirement.

Highlights

  • Enforcement of Plan ID Format: Introduced a regex-based validation in the test registry synchronization tool to ensure all test plan IDs follow a standardized format (e.g., 'Name-1.0').
  • Test Metadata Updates: Updated several test metadata files and the central test registry to comply with the new naming convention for plan IDs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several test plan IDs (such as Authz, CERTZ, Hashing, and bootz) to a versioned format (e.g., Authz-1.0, Certz-6, Hashing-1.0, and bootz-1.0) across their READMEs, metadata files, and the central test registry. Additionally, it updates the sync_test_registry tool to enforce this new naming convention using a regular expression validation check. I have no feedback to provide as there are no review comments and the changes are correct and consistent.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants