[ashishpawar-google]

Summary

Adds OpenConfig telemetry state verification and documentation for three /network-instances/network-instance/ paths across RT-5.1 (basic_static_route_support_test) and RT-5.2 (static_route_with_vlan_interface):

1. /network-instances/network-instance/protocols/protocol/state/enabled (RT-5.1)
2. /network-instances/network-instance/vlans/vlan/state/name (RT-5.2)
3. /network-instances/network-instance/vlans/vlan/state/status (RT-5.2)

Changes

• feature/staticroute/otg_tests/basic_static_route_support_test (RT-5.1):
  • Updated README.md with telemetry parameter coverage for /network-instances/network-instance/protocols/protocol/state/enabled.
  • Added verifyStaticProtocolState in basic_static_route_support_test.go to verify that the STATIC protocol state/enabled leaf is true (respecting deviations.MissingValueForDefaults).
  • Added missing_value_for_defaults: true under cisco_platform_exceptions in metadata.textproto.
• feature/staticroute/otg_tests/static_route_with_vlan_interface (RT-5.2):
  • Updated README.md with configuration and telemetry parameter coverage for /network-instances/network-instance/vlans/vlan/state/name and /network-instances/network-instance/vlans/vlan/state/status.
  • Added verifyVLANState in static_route_with_vlan_interface_test.go to verify VLAN state/name and state/status (ACTIVE) when DeprecatedVlanId is not set.
• internal/cfgplugins:
  • Updated internal/cfgplugins/staticroute.go to explicitly set sp.SetEnabled(true) when configuring the STATIC protocol on the default network instance.
  • Updated internal/cfgplugins/interface.go to configure the VLAN name (vlan_<id>) and status (Vlan_Status_ACTIVE) on the default network instance VLAN entry.

Testing Done

Verified RT-5.1 (basic_static_route_support_test) and RT-5.2 (static_route_with_vlan_interface) across Arista, Cisco, Juniper, and Nokia platforms.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the OpenConfig telemetry verification for static routing and VLAN configurations in the RT-5.1 and RT-5.2 test suites. By explicitly enabling the static protocol and ensuring VLAN states are correctly configured and verified, the changes improve the robustness and coverage of network instance testing across multiple platforms.

Highlights

• Telemetry Verification: Added OpenConfig telemetry state verification for network-instance protocol enabled status and VLAN name/status paths across RT-5.1 and RT-5.2 tests.
• Configuration Updates: Updated internal configuration plugins to explicitly set the static protocol to enabled and configure VLAN parameters (name and status) on the default network instance.
• Documentation: Updated README files for RT-5.1 and RT-5.2 to include coverage for the newly verified telemetry parameters.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #6162 / 617a384

Virtual Devices

Device	Test	Status	Test Documentation	Job	Raw Log
Arista cEOS		RT-1.26: pending authorization RT-1.67: pending authorization	RT-1.26: Basic Static Route Support RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Cisco 8000E		RT-1.26: pending authorization RT-1.67: pending authorization	RT-1.26: Basic Static Route Support RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Cisco XRd		RT-1.26: pending authorization RT-1.67: pending authorization	RT-1.26: Basic Static Route Support RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Juniper ncPTX		RT-1.26: pending authorization RT-1.67: pending authorization	RT-1.26: Basic Static Route Support RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Nokia SR Linux		RT-1.26: pending authorization RT-1.67: pending authorization	RT-1.26: Basic Static Route Support RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Openconfig Lemming		RT-1.26: pending authorization RT-1.67: pending authorization	RT-1.26: Basic Static Route Support RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface

Hardware Devices

Device	Test	Status	Test Documentation	Raw Log
Arista		RT-1.26: pending authorization RT-1.67: pending authorization	RT-1.26: Basic Static Route Support RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Cisco		RT-1.26: pending authorization RT-1.67: pending authorization	RT-1.26: Basic Static Route Support RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Juniper		RT-1.26: pending authorization RT-1.67: pending authorization	RT-1.26: Basic Static Route Support RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Nokia		RT-1.26: pending authorization RT-1.67: pending authorization	RT-1.26: Basic Static Route Support RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface

Help

[gemini-code-assist]

Code Review

This pull request updates the static route and VLAN interface tests to include explicit validation of the static protocol enabled state and VLAN operational status. It also refactors configuration plugins to set the 'enabled' field for static routes and VLANs. The reviewer provided feedback to ensure mandatory state reversion using t.Cleanup() for VLAN status modifications and recommended replacing hardcoded vendor checks with standard deviation accessors to improve test portability.

[ashishpawar-google]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates the static route tests to explicitly configure and validate the enabled state of the static routing protocol. It also adds global VLAN state validation (verifying name and operational status) to the VLAN interface test, updates the ConfigureVlan configuration plugin to consistently use the OpenConfig global VLAN model, and updates the test metadata files with the missing_value_for_defaults platform exception. I have no feedback to provide as there are no review comments and the changes align with the repository style guides.

[ashishpawar-google]

Test Verification Results
RT-1.67: static_route_with_vlan_interface (//third_party/openconfig/featureprofiles/feature/staticroute/otg_tests/static_route_with_vlan_interface)

Arista (arista_7050cx): http://sponge2/2b6ef9a9-fee5-443a-8502-71b1af420ff6 — PASSED (TestStaticRouteVlan/Validate_VLAN_State)
Note: Verified the Validate_VLAN_State subtest in isolation because the remaining traffic subtests (RT-1.67.1 / RT-1.67.2) are currently failing due to a known pre-existing issue tracked in b/529708755 (in the full unfiltered run http://sponge2/64ff8ea6-3e77-47e1-803f-6a2043f6f519, Validate_VLAN_State also passed before hitting b/529708755).
RT-1.26: basic_static_route_support_test (//third_party/openconfig/featureprofiles/feature/staticroute/otg_tests/basic_static_route_support_test)

Arista (arista_7280_j2): http://sponge2/2a5ccaca-7ce2-4fe5-938e-cc79bc599ee3 — PASSED
Cisco (cisco8808): http://sponge2/53f969d3-f671-4f20-b9a9-ba704a9d9107 — PASSED
Juniper (juniper_ptx_10001): http://sponge2/675ec6c5-6c4f-48c6-a722-59f798467236 — PASSED
Nokia (nokia_7250_ixr10e): http://sponge2/1bd17fe9-62ca-445b-b6fb-9a2dc004c5e2 — PASSED