[ashishpawar-google]

Summary

Adds OpenConfig telemetry state verification, README path/canonical OC documentation, and vendor deviations across three feature/system tests:

1. Health-1.1 (feature/system/health/tests/system_generic_health_check)

   • README.md: Document /system/alarms/alarm/state/severity in the procedure and rename the path section header from Config Parameter coverage to Telemetry Parameter coverage.

2. TR-6.1 (feature/system/logging/otg_tests/remote_syslog)

   • README.md: Add the ## Canonical OC section covering /system/logging/remote-servers/remote-server config and state leaves.
   • remote_syslog_test.go:
     • Add verifySyslogState to verify /system/logging/remote-servers/remote-server/state/host, source-address, network-instance, remote-port, and /system/logging/remote-servers/remote-server/selectors/selector/state/facility and severity across all configured remote syslog servers.
     • Register t.Cleanup before configuring the DUT so cleanup always runs if a step fails.
     • Skip unsupported non-default VRF test cases before modifying interface VRF bindings.
   • proto/metadata.proto, internal/deviations/deviations.go, metadata.textproto:
     • Add syslog_uniform_selector_required for platforms requiring uniform facility/severity selectors across remote syslog servers (Arista).
     • Add syslog_default_ni_state_unsupported for platforms omitting state/network-instance when a remote syslog server is in the default VRF (Arista, Juniper).
     • Add syslog_debug_severity_unsupported for platforms not supporting DEBUG severity in OpenConfig remote syslog selectors (Juniper).

3. SYS-4.1 (feature/system/mount_points/tests/system_mount_points_state)

   • README.md: Add /system/mount-points/mount-point/state/storage-component to the Summary, Procedure, Canonical OC, and OpenConfig Path Coverage sections.
   • system_mount_points_state_test.go:
     • Verify /system/mount-points/mount-point/state/storage-component when deviations.SystemMountPointStateFt(dut) is not set.
     • Skip ephemeral /run/user/* runtime mount points that may unmount between list and leaf queries, and remove the utilized + available <= size check that fails on filesystems with reserved blocks or shared pools.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the validation coverage for several OpenConfig telemetry paths across system health, logging, and storage components. By updating test procedures and README documentation, the changes ensure that critical system states are correctly verified and documented, improving the robustness of the system tests.

Highlights

• System Health Check Updates: Updated the generic health check to explicitly validate alarm severities and ensure that major or critical system alarms trigger a test failure.
• Remote Syslog State Verification: Implemented comprehensive state verification for remote syslog servers, ensuring host, source address, network instance, port, and selector configurations match the intended state.
• Mount Point Storage Component Validation: Added validation for the storage-component leaf in system mount point state checks, including updated documentation and canonical examples.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #6152 / ab0b375

Virtual Devices

Device	Test	Status	Test Documentation	Job	Raw Log
Arista cEOS		Health-1.1: pending authorization TR-6.1: pending authorization SYS-4.1: pending authorization	Health-1.1: Generic Health Check TR-6.1: Remote Syslog feature config SYS-4.1: System Mount Points State Verification
Cisco 8000E		Health-1.1: pending authorization TR-6.1: pending authorization SYS-4.1: pending authorization	Health-1.1: Generic Health Check TR-6.1: Remote Syslog feature config SYS-4.1: System Mount Points State Verification
Cisco XRd		Health-1.1: pending authorization TR-6.1: pending authorization SYS-4.1: pending authorization	Health-1.1: Generic Health Check TR-6.1: Remote Syslog feature config SYS-4.1: System Mount Points State Verification
Juniper ncPTX		Health-1.1: pending authorization TR-6.1: pending authorization SYS-4.1: pending authorization	Health-1.1: Generic Health Check TR-6.1: Remote Syslog feature config SYS-4.1: System Mount Points State Verification
Nokia SR Linux		Health-1.1: pending authorization TR-6.1: pending authorization SYS-4.1: pending authorization	Health-1.1: Generic Health Check TR-6.1: Remote Syslog feature config SYS-4.1: System Mount Points State Verification
Openconfig Lemming		Health-1.1: pending authorization TR-6.1: pending authorization SYS-4.1: pending authorization	Health-1.1: Generic Health Check TR-6.1: Remote Syslog feature config SYS-4.1: System Mount Points State Verification

Hardware Devices

Device	Test	Status	Test Documentation	Raw Log
Arista		Health-1.1: pending authorization TR-6.1: pending authorization SYS-4.1: pending authorization	Health-1.1: Generic Health Check TR-6.1: Remote Syslog feature config SYS-4.1: System Mount Points State Verification
Cisco		Health-1.1: pending authorization TR-6.1: pending authorization SYS-4.1: pending authorization	Health-1.1: Generic Health Check TR-6.1: Remote Syslog feature config SYS-4.1: System Mount Points State Verification
Juniper		Health-1.1: pending authorization TR-6.1: pending authorization SYS-4.1: pending authorization	Health-1.1: Generic Health Check TR-6.1: Remote Syslog feature config SYS-4.1: System Mount Points State Verification
Nokia		Health-1.1: pending authorization TR-6.1: pending authorization SYS-4.1: pending authorization	Health-1.1: Generic Health Check TR-6.1: Remote Syslog feature config SYS-4.1: System Mount Points State Verification

Help

[gemini-code-assist]

Code Review

This pull request enhances several system health, logging, and mount point tests by adding verification for critical alarms, remote syslog state, and storage components. Feedback on the changes highlights opportunities to optimize gNMI queries by batching operations in verifySyslogState and combining redundant queries in TestSystemAlarms. Additionally, it is recommended to register t.Cleanup earlier in the test lifecycle to guarantee proper state reversion in case of early failures.

[ashishpawar-google]

/gemini-review

[ashishpawar-google]

/gemini review

[gemini-code-assist]

Code Review

This pull request adds new OpenConfig deviations for remote syslog configuration (SyslogUniformSelectorRequired, SyslogDefaultNIStateUnsupported, and SyslogDebugSeverityUnsupported) and integrates them into the remote syslog test suite, alongside a new verifySyslogState function. It also updates the system mount points test to validate the storage-component state and skip ephemeral user runtime mount points. The review feedback points out that the SyslogDebugSeverityUnsupported deviation is overloaded to control unrelated behaviors—specifically, bypassing loopback interface selection and scaling down traffic parameters—and recommends defining dedicated deviations to maintain clean separation of concerns.