[ashishpawar-google]

Summary

Adds OpenConfig README and test coverage for 5 interface/subinterface telemetry state paths across gNMI-1.5, gNMI-1.11, and gNMI-1.28:

1. gNMI-1.5 (feature/gnmi/otg_tests/telemetry_port_speed_test):

   • Added coverage for /interfaces/interface/ethernet/state/negotiated-port-speed.
   • Verified negotiated-port-speed presence on physical Ethernet member ports and validated the speed against the configured port speed when auto-negotiate is enabled.
   • Added deviation negotiated_port_speed_unsupported for Nokia (b/572214470).

2. gNMI-1.11 (feature/interface/otg_tests/telemetry_interface_packet_counters_test):

   • Added coverage for:
     • /interfaces/interface/subinterfaces/subinterface/state/counters/in-unicast-pkts
     • /interfaces/interface/subinterfaces/subinterface/state/counters/out-multicast-pkts
   • Guarded subinterface IPv4/IPv6 packet counter streaming checks with !deviations.SubinterfacePacketCountersMissing(dut) and enabled subinterface_packet_counters_missing for Juniper in metadata.textproto.
   • Increased packet counter rate tolerance from 70 to 100 to prevent false failures from sample interval polling jitter.

3. gNMI-1.28 (feature/gnmi/tests/telemetry_interfaces_test):

   • Added coverage for:
     • /interfaces/interface/subinterfaces/subinterface/state/ifindex
     • /interfaces/interface/subinterfaces/subinterface/state/name
   • Added deviations:
     • subinterface_ifindex_unsupported for Juniper (b/572208368).
     • subinterface_name_unsupported for Cisco (b/572214473).
   • Added require_routed_subinterface_0 handling for Arista subinterface creation and preserved canonical interface casing on dut.Port(t, "port1").Name().

[OpenConfigBot]

Pull Request Functional Test Report for #6150 / 32604c1

Virtual Devices

Device	Test	Status	Test Documentation	Job	Raw Log
Arista cEOS		gNMI-1.5: pending authorization gNMI-1.28: pending authorization gNMI-1.11: pending authorization	gNMI-1.5: Telemetry: Port Speed Test gNMI-1.28: Telemetry: Interface openconfig validation. gNMI-1.11: Telemetry: Interface Packet Counters
Cisco 8000E		gNMI-1.5: pending authorization gNMI-1.28: pending authorization gNMI-1.11: pending authorization	gNMI-1.5: Telemetry: Port Speed Test gNMI-1.28: Telemetry: Interface openconfig validation. gNMI-1.11: Telemetry: Interface Packet Counters
Cisco XRd		gNMI-1.5: pending authorization gNMI-1.28: pending authorization gNMI-1.11: pending authorization	gNMI-1.5: Telemetry: Port Speed Test gNMI-1.28: Telemetry: Interface openconfig validation. gNMI-1.11: Telemetry: Interface Packet Counters
Juniper ncPTX		gNMI-1.5: pending authorization gNMI-1.28: pending authorization gNMI-1.11: pending authorization	gNMI-1.5: Telemetry: Port Speed Test gNMI-1.28: Telemetry: Interface openconfig validation. gNMI-1.11: Telemetry: Interface Packet Counters
Nokia SR Linux		gNMI-1.5: pending authorization gNMI-1.28: pending authorization gNMI-1.11: pending authorization	gNMI-1.5: Telemetry: Port Speed Test gNMI-1.28: Telemetry: Interface openconfig validation. gNMI-1.11: Telemetry: Interface Packet Counters
Openconfig Lemming		gNMI-1.5: pending authorization gNMI-1.28: pending authorization gNMI-1.11: pending authorization	gNMI-1.5: Telemetry: Port Speed Test gNMI-1.28: Telemetry: Interface openconfig validation. gNMI-1.11: Telemetry: Interface Packet Counters

Hardware Devices

Device	Test	Status	Test Documentation	Raw Log
Arista		gNMI-1.5: pending authorization gNMI-1.28: pending authorization gNMI-1.11: pending authorization	gNMI-1.5: Telemetry: Port Speed Test gNMI-1.28: Telemetry: Interface openconfig validation. gNMI-1.11: Telemetry: Interface Packet Counters
Cisco		gNMI-1.5: pending authorization gNMI-1.28: pending authorization gNMI-1.11: pending authorization	gNMI-1.5: Telemetry: Port Speed Test gNMI-1.28: Telemetry: Interface openconfig validation. gNMI-1.11: Telemetry: Interface Packet Counters
Juniper		gNMI-1.5: pending authorization gNMI-1.28: pending authorization gNMI-1.11: pending authorization	gNMI-1.5: Telemetry: Port Speed Test gNMI-1.28: Telemetry: Interface openconfig validation. gNMI-1.11: Telemetry: Interface Packet Counters
Nokia		gNMI-1.5: pending authorization gNMI-1.28: pending authorization gNMI-1.11: pending authorization	gNMI-1.5: Telemetry: Port Speed Test gNMI-1.28: Telemetry: Interface openconfig validation. gNMI-1.11: Telemetry: Interface Packet Counters

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the OpenConfig telemetry test coverage by adding validation for several interface and subinterface state paths. It also introduces new deviation mechanisms to accommodate platform-specific limitations across different vendors, ensuring test stability and reliability in heterogeneous environments.

Highlights

• Telemetry Coverage Expansion: Added test coverage for negotiated-port-speed, subinterface ifindex, subinterface name, and specific packet counters (in-unicast-pkts, out-multicast-pkts) across multiple gNMI test suites.
• Infrastructure & Deviations: Introduced new platform deviations for Nokia, Juniper, and Cisco to handle unsupported telemetry paths and added necessary metadata and protobuf updates to support these deviations.
• Test Robustness: Increased packet counter rate tolerance to 100 to mitigate jitter-related failures and added logic to handle routed subinterface configuration for Arista devices.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds telemetry validation for negotiated port speed, subinterface name and ifindex, and subinterface packet counters, introducing several new platform deviations to handle vendor-specific limitations. The review feedback highlights two key improvement opportunities: first, replacing direct gnmi.Get and gnmi.Lookup calls with gnmi.Await and gnmi.Watch in telemetry_port_speed_test.go to prevent flaky test failures in accordance with the style guide; second, optimizing redundant gNMI operations in telemetry_interfaces_test.go by retrieving both presence and value in a single .Val() call.

[ashishpawar-google]

/gemini-review

[ashishpawar-google]

Update Test Pass logs in Mirror bug.