[pshivash]

With #4371, changes were done to initialize the static protocol, however static-routes container too is required in the same, which is added now.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

[gemini-code-assist]

Summary of Changes

Hello @pshivash, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical initialization step for static routing within the OpenConfig feature profiles. It ensures that when the static protocol is configured, an empty container for static routes is explicitly created. This prevents potential issues where subsequent static route configurations might fail due to the absence of the parent container, thereby improving the robustness and completeness of the network instance setup.

Highlights

• Static Route Initialization: This pull request adds the initialization of an empty static-routes container for the STATIC protocol type. This is a follow-up to a previous change that initialized the static protocol but missed this specific container.
• Configuration Update: The change involves adding Static: map[string]*oc.NetworkInstance_Protocol_Static{} to the NetworkInstance_Protocol configuration within the configureStaticRoute function.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #4905 / 1589a77

Virtual Devices

Device	Test	Status	Test Documentation	Job	Raw Log
Arista cEOS		RT-5.3: pending authorization	RT-5.3: Aggregate Balancing
Cisco 8000E		RT-5.3: pending authorization	RT-5.3: Aggregate Balancing
Cisco XRd		RT-5.3: pending authorization	RT-5.3: Aggregate Balancing
Juniper ncPTX		RT-5.3: pending authorization	RT-5.3: Aggregate Balancing
Nokia SR Linux		RT-5.3: pending authorization	RT-5.3: Aggregate Balancing
Openconfig Lemming		RT-5.3: pending authorization	RT-5.3: Aggregate Balancing

Hardware Devices

Device	Test	Status	Test Documentation	Raw Log
Arista		RT-5.3: pending authorization	RT-5.3: Aggregate Balancing
Cisco		RT-5.3: pending authorization	RT-5.3: Aggregate Balancing
Juniper		RT-5.3: pending authorization	RT-5.3: Aggregate Balancing
Nokia		RT-5.3: pending authorization	RT-5.3: Aggregate Balancing

Help

[gemini-code-assist]

Code Review

The pull request modifies balancing_test.go by adding an empty Static container to the NetworkInstance_Protocol configuration within the configureStaticRoute function. No review comments were provided for these changes.

[coveralls]

Pull Request Test Coverage Report for Build 21093644933

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 9.969%

---

Totals
Change from base Build 21088802777:	0.0%
Covered Lines:	2227
Relevant Lines:	22339

---

💛 - Coveralls

[pshivash]

@AmrNJ Request you to review the changes and the comments/response. Reaching out since @dplore asked me to check with you for further review.

cc: @trathod1

[AmrNJ]

/gemini review

[gemini-code-assist]

Code Review

This pull request attempts to initialize an empty Static map container within the static protocol configuration in balancing_test.go. However, the reviewer noted that in ygot-generated Go code, empty map fields representing OpenConfig lists are omitted during serialization due to omitempty behavior, making this change a no-op. It is recommended to revert this addition as the static routes are already handled atomically in a subsequent batch operation.