Skip to content

enhance: listen on favourite events - #3019

Merged
JammingBen merged 7 commits into
mainfrom
reacting-to-favorite-sse-events
Aug 4, 2026
Merged

enhance: listen on favourite events#3019
JammingBen merged 7 commits into
mainfrom
reacting-to-favorite-sse-events

Conversation

@schweigisito

Copy link
Copy Markdown
Member

Description

This PR may fix #3016 by listening on favourite SSEs sent by backend.

Related Issue

How Has This Been Tested?

  • This PR has been tested with a backend in which enhance: send events for adding/removing favourite items聽opencloud#3229 has been applied
  • Opened two browser sessions with same user
  • In window A a file has been added to and removed from favourites
  • The changes made it immediately to browser window B by reacting to item-favorite-added and item-favorite-removed events on the SSE connection.

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Comment thread packages/web-runtime/src/container/sse/files.ts Outdated

@JammingBen JammingBen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JammingBen
JammingBen merged commit 5338122 into main Aug 4, 2026
30 checks passed
@github-project-automation github-project-automation Bot moved this from Qualification to Done in OpenCloud Team Board Aug 4, 2026
@JammingBen
JammingBen deleted the reacting-to-favorite-sse-events branch August 4, 2026 11:53
@openclouders openclouders mentioned this pull request Aug 4, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

UI reacts on SSEs for added/removed favorite-items

2 participants