fix: notification handling for share removal and space membership expiry - #3257
fix: notification handling for share removal and space membership expiry #3257maki5 wants to merge 9 commits into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 26 |
🟢 Coverage 39.04% diff coverage · +0.02% coverage variation
Metric Results Coverage variation ✅ +0.02% coverage variation (-1.00%) Diff coverage ✅ 39.04% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (8478b5d) 84082 19349 23.01% Head commit (1cbc833) 84206 (+124) 19397 (+48) 23.04% (+0.02%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3257) 146 57 39.04% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
Please add a description. |
|
the last merge from main somehow messed this up a bit. @butonic @pbleser-oc Can you help to rebase this properly? @maki5 I tested you changes, looking good to me! 👍 We should enable this feature by default, i checked with @tbsbdr That means we need to change the default config by setting this StructValue https://github.com/opencloud-eu/opencloud/blob/main/services/frontend/pkg/config/config.go#L62 in the defaultconfig.go to |
Notifications service
ShareRemovedevent (backport of feat: Add email notification for share removed owncloud/ocis#10915):new email template, event dispatch and grouped-mail support, and the
mail option is enabled by default in the notification settings
handleSpaceMembershipExpired: resolve the space name via aprepare helper and send from the default email sender, dropping the
dependency on the unresolvable space owner lookup
Userlog service
SpaceMembershipExpiredthatresolves only the space (the template does not reference a user),
so the in-app notification no longer fails on the unresolvable space
owner placeholder
granular in-app notifications (previously we didn't handle it's disabling)
Dependencies
Backport and fix of space membership expired event reva#766), bringing:
SpaceMembershipExpiredevent when the decomposedfs cleans up expired space grants "on
access"
SpaceMembershipExpiredinstead ofShareExpiredfor expired space-root shares