Repository navigation
feat(api): expand Live Decision item and question types - #3034
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 40227145465 --repo openai/openai-node \
--name castiron-custom-code-40227145465-1 --dir /tmp/castiron-custom-code-40227145465-1
git apply --stat /tmp/castiron-custom-code-40227145465-1/custom-code.patch
cat /tmp/castiron-custom-code-40227145465-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin d8931e7facfd0b453cc1683c31c60be8cc1ae37e 8fe7f8167b445dd098f69e15534928fb35066d8d
python3 scripts/castiron/custom_code_report.py report \
--base d8931e7facfd0b453cc1683c31c60be8cc1ae37e \
--head 8fe7f8167b445dd098f69e15534928fb35066d8d --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-8fe7f8167b44
cat /tmp/castiron-custom-code-8fe7f8167b44/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54942c6bbd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
df8e529 to
20c0b1a
Compare
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed 20c0b1a632f8 against d8931e7facfd. I cannot approve this revision.
The policy selector should carry each verified PR head and number together; the inline comment explains how to remove the redundant discovery mode.
I also confirmed that two existing compatibility findings still apply at this head:
- Restore the published
Assistants.AssistantStreamexport: #3034 (comment) - Preserve the old Live
ItemandQuestionParam*type paths alongside the new types: #3034 (comment)
Please preserve these names in generation and add public-import type coverage. The expanded message, tool, and structured-question shapes otherwise match the transformed schema.
Source-only review; I did not run candidate code or tests. Hosted checks: 17 skipped, 25 success.
20c0b1a to
cc71a4e
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Re-reviewed cc71a4e7d078 against d8931e7facfd. The Assistants namespace export is restored, and all four checkpoint-permission methods use admin-key auth.
The Live compatibility issue still blocks approval: DecisionItemCreateEvent.Item, the corresponding created-event types, and the old nested question types remain missing. Existing consumers that name them fail to compile. Please preserve those public names in generation and add public-import type coverage: #3034 (comment)
I accept the shared policy-selector redesign as separate generator work, per your scope clarification. It is deferred, not fixed. I found no additional issues in this re-review.
Source-only review; I did not run candidate code or tests. Hosted checks: 25 skipped, 29 success.
Castiron-Internal-PR: openai/openai-node-internal#374 Castiron-Source-SHA: 77fa18fb28191007fb1b173018b972a500ed5036 Castiron-Public-Base-SHA: d8931e7
cc71a4e to
8fe7f81
Compare
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed 8fe7f8167b44 against d8931e7facfd. The published Live Item and QuestionParam type paths are restored, including their nested types. The expanded item and question unions remain available. I found no remaining blocking issue across the 17 changed files. The shared selector redesign remains a separate generator follow-up, as agreed.
Source-only review; I did not run candidate code or tests. The exact-head hosted checks passed or were skipped, including successful Node test jobs and the custom-code budget checks. The author reports a separate TypeScript consumer check.
Summary
Support more message, tool call, and question input types in Live Decisions.
Changes