Skip to content

chore(api): clarify decision creation documentation - #2913

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-265
Oct 11, 2026
Merged

chore(api): clarify decision creation documentation#2913
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-265

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Clarifies the input formats and refusal results for decision creation.

Changes

  • Describe text and image inputs, the 128-image limit, and per-question refusal results.

@jbeckwith-oai
chore(api): clarify decision creation documentation
d191981 
Castiron-Internal-PR: openai/openai-node-internal#265
Castiron-Source-SHA: ac00c6b506f59bf3ecfe730021a64abd3cf3d7f2
Castiron-Public-Base-SHA: d6d80a1
@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 11, 2026 02:59
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 11, 2026 02:59
@github-actions

github-actions Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: d6d80a13b7482bab9c7b25d5ada73ec97eb684d6.

✅ No new custom-code files detected.

50 mixed files remain; 0 existing customizations changed.

Compared d6d80a13b748 → d191981b5962. Generated baselines verified.

50 existing customizations unchanged
  • api.md
  • scripts/castiron/CUSTOM_CODE.md
  • scripts/castiron/custom_code_budget.py
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_budget.py
  • src/client.ts
  • src/resources/audio/transcriptions.ts
  • src/resources/audio/translations.ts
  • src/resources/beta/agents/agents.ts
  • src/resources/beta/agents/environments/environments.ts
  • src/resources/beta/agents/environments/files.ts
  • src/resources/beta/agents/sessions/artifacts.ts
  • src/resources/beta/agents/sessions/sessions.ts
  • src/resources/beta/assistants.ts
  • src/resources/beta/beta.ts
  • src/resources/beta/index.ts
  • src/resources/beta/responses/internal-base.ts
  • src/resources/beta/responses/responses.ts
  • src/resources/beta/responses/ws-base.ts
  • src/resources/beta/responses/ws.ts
  • src/resources/beta/threads/index.ts
  • src/resources/beta/threads/runs/index.ts
  • src/resources/beta/threads/runs/runs.ts
  • src/resources/beta/threads/threads.ts
  • src/resources/chat/completions/completions.ts
  • src/resources/chat/completions/index.ts
  • src/resources/conversations/index.ts
  • src/resources/embeddings.ts
  • src/resources/files.ts
  • src/resources/fine-tuning/checkpoints/permissions.ts
  • src/resources/images.ts
  • src/resources/live/forks/ws-base.ts
  • src/resources/live/forks/ws.ts
  • src/resources/live/sideband/ws-base.ts
  • src/resources/live/sideband/ws.ts
  • src/resources/live/ws-base.ts
  • src/resources/live/ws.ts
  • src/resources/responses/internal-base.ts
  • src/resources/responses/responses.ts
  • src/resources/responses/ws-base.ts

10 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 38106949039 --repo openai/openai-node \
  --name castiron-custom-code-38106949039-1 --dir /tmp/castiron-custom-code-38106949039-1
git apply --stat /tmp/castiron-custom-code-38106949039-1/custom-code.patch
cat /tmp/castiron-custom-code-38106949039-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin d6d80a13b7482bab9c7b25d5ada73ec97eb684d6 d191981b596208b0046e2ef7bb38aeb0ea346d7c
python3 scripts/castiron/custom_code_report.py report \
  --base d6d80a13b7482bab9c7b25d5ada73ec97eb684d6 \
  --head d191981b596208b0046e2ef7bb38aeb0ea346d7c --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-d191981b5962
cat /tmp/castiron-custom-code-d191981b5962/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T03:00:30.945686Z d191981 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-11T03:02:21.658496Z d191981 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 7.87s for Node SDK PR #2913.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 136ms
tests/chat-completions-create.test.ts ✅ Passed 180ms
tests/chat-completions-stream.test.ts ✅ Passed 118ms
tests/files-content-binary.test.ts ✅ Passed 183ms
tests/files-create-multipart.test.ts ✅ Passed 208ms
tests/files-list-pagination.test.ts ✅ Passed 137ms
tests/initialize-config.test.ts ✅ Passed 155ms
tests/instance-isolation.test.ts ✅ Passed 146ms
tests/models-list.test.ts ✅ Passed 157ms
tests/responses-background-lifecycle.test.ts ✅ Passed 272ms
tests/responses-body-method-errors.test.ts ✅ Passed 247ms
tests/responses-cancel-timeout.test.ts ✅ Passed 220ms
tests/responses-cancel.test.ts ✅ Passed 167ms
tests/responses-compact-retries.test.ts ✅ Passed 181ms
tests/responses-compact.test.ts ✅ Passed 167ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 178ms
tests/responses-create-advanced.test.ts ✅ Passed 216ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.078s
tests/responses-create-errors.test.ts ✅ Passed 139ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 100ms
tests/responses-create-retries.test.ts ✅ Passed 170ms
tests/responses-create-stream-failures.test.ts ✅ Passed 106ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.151s
tests/responses-create-stream-wire.test.ts ✅ Passed 1.141s
tests/responses-create-stream.test.ts ✅ Passed 105ms
tests/responses-create-terminal-states.test.ts ✅ Passed 206ms
tests/responses-create-timeout.test.ts ✅ Passed 209ms
tests/responses-create.test.ts ✅ Passed 197ms
tests/responses-delete.test.ts ✅ Passed 168ms
tests/responses-input-items-errors.test.ts ✅ Passed 162ms
tests/responses-input-items-list.test.ts ✅ Passed 179ms
tests/responses-input-items-options.test.ts ✅ Passed 135ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 250ms
tests/responses-input-tokens-count.test.ts ✅ Passed 179ms
tests/responses-malformed-inputs.test.ts ✅ Passed 825ms
tests/responses-not-found-errors.test.ts ✅ Passed 198ms
tests/responses-parse.test.ts ✅ Passed 200ms
tests/responses-retrieve-retries.test.ts ✅ Passed 203ms
tests/responses-retrieve.test.ts ✅ Passed 156ms
tests/responses-stored-method-errors.test.ts ✅ Passed 372ms
tests/retry-behavior.test.ts ✅ Passed 3.015s
tests/sdk-error-shape.test.ts ✅ Passed 236ms

View OkTest run #38106933665

SDK merge (27dc10baa55c) · head (d191981b5962) · base (d6d80a13b748) · OkTest (57341bb8c17e)

markstuart-oai
markstuart-oai approved these changes Oct 11, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed d191981b596208b0046e2ef7bb38aeb0ea346d7c. No actionable findings.

The full schema changes only the POST /decisions description. The generated documentation agrees with that wording and preserves the existing input restrictions, question order, and refusal semantics. The non-comment TypeScript source is unchanged. The change adds no structural complexity.

The Node test matrix and external OkTest run were still in progress at the final check. Source and static analysis only; I ran no repository tests or generation.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 11, 2026
Merged via the queue into main with commit 1c380ea Oct 11, 2026
63 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-265 branch October 11, 2026 03:10
@openai-sdks openai-sdks Bot mentioned this pull request Oct 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbeckwith-oai @markstuart-oai