Skip to content

chore(api): clarify Decisions question and answer descriptions - #2910

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-261
Oct 10, 2026
Merged

chore(api): clarify Decisions question and answer descriptions#2910
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-261

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Clarifies the supported input, question types, and declined answers in the Decisions API.

Changes

  • Describe predicate, choice, and score questions.
  • Clarify shared evidence inputs and that one declined question does not prevent other answers.

@jbeckwith-oai
chore(api): clarify Decisions question and answer descriptions
8d7c6bf 
Castiron-Internal-PR: openai/openai-node-internal#261
Castiron-Source-SHA: 7142ed7b92495101ce2eea02e93f5cc06cd616dc
Castiron-Public-Base-SHA: 75a6810
@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 10, 2026 21:30
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 10, 2026 21:30
@github-actions

github-actions Bot commented Oct 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: 75a681079f07d0aaaffb88a79b637abf67b8db7a.

✅ No new custom-code files detected.

50 mixed files remain; 0 existing customizations changed.

Compared 75a681079f07 → 8d7c6bfbb9a6. Generated baselines verified.

50 existing customizations unchanged
  • api.md
  • scripts/castiron/CUSTOM_CODE.md
  • scripts/castiron/custom_code_budget.py
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_budget.py
  • src/client.ts
  • src/resources/audio/transcriptions.ts
  • src/resources/audio/translations.ts
  • src/resources/beta/agents/agents.ts
  • src/resources/beta/agents/environments/environments.ts
  • src/resources/beta/agents/environments/files.ts
  • src/resources/beta/agents/sessions/artifacts.ts
  • src/resources/beta/agents/sessions/sessions.ts
  • src/resources/beta/assistants.ts
  • src/resources/beta/beta.ts
  • src/resources/beta/index.ts
  • src/resources/beta/responses/internal-base.ts
  • src/resources/beta/responses/responses.ts
  • src/resources/beta/responses/ws-base.ts
  • src/resources/beta/responses/ws.ts
  • src/resources/beta/threads/index.ts
  • src/resources/beta/threads/runs/index.ts
  • src/resources/beta/threads/runs/runs.ts
  • src/resources/beta/threads/threads.ts
  • src/resources/chat/completions/completions.ts
  • src/resources/chat/completions/index.ts
  • src/resources/conversations/index.ts
  • src/resources/embeddings.ts
  • src/resources/files.ts
  • src/resources/fine-tuning/checkpoints/permissions.ts
  • src/resources/images.ts
  • src/resources/live/forks/ws-base.ts
  • src/resources/live/forks/ws.ts
  • src/resources/live/sideband/ws-base.ts
  • src/resources/live/sideband/ws.ts
  • src/resources/live/ws-base.ts
  • src/resources/live/ws.ts
  • src/resources/responses/internal-base.ts
  • src/resources/responses/responses.ts
  • src/resources/responses/ws-base.ts

10 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 38087940045 --repo openai/openai-node \
  --name castiron-custom-code-38087940045-1 --dir /tmp/castiron-custom-code-38087940045-1
git apply --stat /tmp/castiron-custom-code-38087940045-1/custom-code.patch
cat /tmp/castiron-custom-code-38087940045-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 75a681079f07d0aaaffb88a79b637abf67b8db7a 8d7c6bfbb9a6e47de425650e95e1d9d3143ea6c8
python3 scripts/castiron/custom_code_report.py report \
  --base 75a681079f07d0aaaffb88a79b637abf67b8db7a \
  --head 8d7c6bfbb9a6e47de425650e95e1d9d3143ea6c8 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-8d7c6bfbb9a6
cat /tmp/castiron-custom-code-8d7c6bfbb9a6/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T21:32:14.216847Z 8d7c6bf Draft marked ready
🔒 Security Review ✅ Completed 2026-10-10T21:33:29.556476Z 8d7c6bf Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Oct 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 8.605s for Node SDK PR #2910.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 231ms
tests/chat-completions-create.test.ts ✅ Passed 280ms
tests/chat-completions-stream.test.ts ✅ Passed 140ms
tests/files-content-binary.test.ts ✅ Passed 191ms
tests/files-create-multipart.test.ts ✅ Passed 224ms
tests/files-list-pagination.test.ts ✅ Passed 161ms
tests/initialize-config.test.ts ✅ Passed 178ms
tests/instance-isolation.test.ts ✅ Passed 211ms
tests/models-list.test.ts ✅ Passed 224ms
tests/responses-background-lifecycle.test.ts ✅ Passed 195ms
tests/responses-body-method-errors.test.ts ✅ Passed 241ms
tests/responses-cancel-timeout.test.ts ✅ Passed 241ms
tests/responses-cancel.test.ts ✅ Passed 219ms
tests/responses-compact-retries.test.ts ✅ Passed 200ms
tests/responses-compact.test.ts ✅ Passed 217ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 174ms
tests/responses-create-advanced.test.ts ✅ Passed 156ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.016s
tests/responses-create-errors.test.ts ✅ Passed 163ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 172ms
tests/responses-create-retries.test.ts ✅ Passed 210ms
tests/responses-create-stream-failures.test.ts ✅ Passed 124ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.176s
tests/responses-create-stream-wire.test.ts ✅ Passed 1.378s
tests/responses-create-stream.test.ts ✅ Passed 125ms
tests/responses-create-terminal-states.test.ts ✅ Passed 214ms
tests/responses-create-timeout.test.ts ✅ Passed 238ms
tests/responses-create.test.ts ✅ Passed 256ms
tests/responses-delete.test.ts ✅ Passed 177ms
tests/responses-input-items-errors.test.ts ✅ Passed 169ms
tests/responses-input-items-list.test.ts ✅ Passed 207ms
tests/responses-input-items-options.test.ts ✅ Passed 166ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 261ms
tests/responses-input-tokens-count.test.ts ✅ Passed 176ms
tests/responses-malformed-inputs.test.ts ✅ Passed 968ms
tests/responses-not-found-errors.test.ts ✅ Passed 253ms
tests/responses-parse.test.ts ✅ Passed 161ms
tests/responses-retrieve-retries.test.ts ✅ Passed 220ms
tests/responses-retrieve.test.ts ✅ Passed 180ms
tests/responses-stored-method-errors.test.ts ✅ Passed 377ms
tests/retry-behavior.test.ts ✅ Passed 3.151s
tests/sdk-error-shape.test.ts ✅ Passed 253ms

View OkTest run #38087919427

SDK merge (9b1b35460ea9) · head (8d7c6bfbb9a6) · base (75a681079f07) · OkTest (57341bb8c17e)

markstuart-oai
markstuart-oai approved these changes Oct 10, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8d7c6bfbb9a6e47de425650e95e1d9d3143ea6c8 against 75a681079f07d0aaaffb88a79b637abf67b8db7a. No findings.

The five Decisions schema descriptions and generated documentation are consistent. The input, question and refusal interface docs remain consistent. Executable code, validation and signatures are unchanged. The public generation reference resolves to the expected generated contents.

CI is still running for this commit, with no failed checks observed as of 21:34 UTC. I reviewed immutable source and hosted checks; I did not run repository tests or generation.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 10, 2026
Merged via the queue into main with commit b5c7300 Oct 10, 2026
63 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-261 branch October 10, 2026 21:43
@openai-sdks openai-sdks Bot mentioned this pull request Oct 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbeckwith-oai @markstuart-oai