Repository navigation
Conversation
openruyi-bot
Bot
added
Community: Contribution
RevySR
reviewed
Oct 31, 2026
Author
There was a problem hiding this comment.
The comment "?" does not specify a question or requested change I can address.
openruyi-bot
Bot
added
Workflow: In Review
openruyi-bot
Bot
removed
the
Workflow: In Review
Member
|
This Pull Request is extremely poor quality. It appears to be generated by an LLM (or agent), as it does not adhere to the guidelines outlined in I will be closing this Pull Request. We seek quality contributions, not subpar submissions generated by AI that haven't been reviewed by a human. |
openruyi-bot
Bot
added
the
Workflow: In Review
jay23606
deleted the
pr-go/1558-binutils-risc-v-ld-test-run-pr19719-fun-
branch
November 2, 2026 22:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The binutils %check workaround deleted both pr19719 tests unconditionally, masking a known RISC-V failure during the PGO training run.
Change
Keep both tests enabled and mark them as expected failures on RISC-V while upstream ld/32983 remains unresolved.
Testing
python tests/test_binutils_pr19719_workaround.py(passed)git diff --check(passed)untested: CONTRIBUTING does not mention tests
Fixes #1558