Skip to content

Add support in LSP eval integration for selection evaluation - #504

Merged
charlieegan3 merged 3 commits into
open-policy-agent:mainfrom
charlieegan3:inline-eval-coverage
Oct 1, 2026
Merged

charlieegan3 merged 3 commits into
open-policy-agent:mainfrom
charlieegan3:inline-eval-coverage

Conversation

@charlieegan3

Copy link
Copy Markdown
Collaborator
Screen.Recording.20.mov

Comment thread .markdownlint.yaml
# MD044/proper-names - Proper names should have the correct capitalization
MD044:
# List of proper names
names: [

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some dprint issues and it was easier to make this a normal yaml list.

@srenatus srenatus left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/output.ts
@@ -0,0 +1,45 @@
import * as vscode from "vscode";

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just extracted from the main ext file

@charlieegan3
charlieegan3 force-pushed the inline-eval-coverage branch 2 times, most recently from 25d9240 to f888666 Compare September 30, 2026 12:40

@anderseknert anderseknert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread .markdownlint.yaml Outdated
"Terraform",
"WebAssembly",
- "ACR"
- "AKS"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at this, do these items actually need quoting? 🙂

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah not needed, have removed!

I had some issues with running the ext in debug mode and linting/spelling

Signed-off-by: Charlie Egan <charlie_egan@apple.com>
Signed-off-by: Charlie Egan <charlie_egan@apple.com>
Signed-off-by: Charlie Egan <charlie_egan@apple.com>
@charlieegan3
charlieegan3 enabled auto-merge October 1, 2026 15:22
@charlieegan3
charlieegan3 added this pull request to the merge queue Oct 1, 2026
Merged via the queue into open-policy-agent:main with commit cde4108 Oct 1, 2026
3 checks passed
@charlieegan3
charlieegan3 deleted the inline-eval-coverage branch October 1, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants