Repository navigation
Address issue in marshalling of non-object keys - #2116
Merged
anderseknert merged 1 commit intoOct 6, 2026
Merged
Conversation
Member
|
I think this was fixed as part of the JSON v2 PR. Sorry, had missed that you fixed it too 😅 Do you think main is good as is now? |
charlieegan3
force-pushed
the
eval-selection-round-trip
branch
from
October 6, 2026 14:32
1483f65 to
9aeaae9
Compare
Evaluating a query like `{1: "a"}` in the language server failed.
The encoder wrote number, bool and similar keys as raw JSON values,
not as strings, and dropped the member value. Those keys now use their
string form, like other non-string keys.
Signed-off-by: Charlie Egan <charlie_egan@apple.com>
charlieegan3
force-pushed
the
eval-selection-round-trip
branch
from
October 6, 2026 14:42
9aeaae9 to
840ba8e
Compare
charlieegan3
changed the title
Contributor
Author
|
Have updated the PR description, as there is still an issue non obj keys. |
Contributor
Author
|
But removed the rest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follows
#2104 (comment)
but #2118 addresses original issue. This is just an extra fix.