Skip to content

fix(release): write the cask postflight as install steps - #53

Merged
piekstra merged 1 commit into
mainfrom
piekstra/cask-install-steps
Oct 28, 2026
Merged

piekstra merged 1 commit into
mainfrom
piekstra/cask-install-steps

Conversation

@piekstra

Copy link
Copy Markdown
Member

Summary

The release workflow installs GoReleaser ~> v2, which now resolves to 2.19. That version deprecates homebrew_casks.hooks.post.install, and the workflow's goreleaser check fails on any deprecated property, so the next release would fail before building.

  • The cask postflight moves to install_steps with {{ .StagedPath }}. GoReleaser renders it as a postflight_steps block with the absolute {{staged_path}} token, which the shared alias job's modernizer passes through unchanged.
  • GoReleaser pins in workflows move to v2.19.0, which reads install_steps.

Verification

  • goreleaser check with 2.19.0 passes for .goreleaser.yml; on main it fails with the deprecation.
  • goreleaser release --snapshot --clean --skip=publish,before,sign,validate renders each cask's postflight_steps block as run "/usr/bin/xattr", args: ["-dr", "com.apple.quarantine", "{{staged_path}}/<binary>"].

Model: Claude Opus 5.5 (1M context, xhigh effort) in Claude Code.

The release workflow installs GoReleaser `~> v2`, which now resolves to
2.19. That version deprecates `homebrew_casks.hooks.post.install`, and the
workflow's `goreleaser check` fails on any deprecated property, so the
next release would fail before building.

Move the postflight to `install_steps` with `{{ .StagedPath }}`.
GoReleaser renders it as a `postflight_steps` block with the absolute
`{{staged_path}}` token, which the shared modernizer passes through
unchanged. GoReleaser pins in workflows move to v2.19.0, which reads
`install_steps`.

Twapp-Session: f18916e9-4ebc-4371-a3db-eb58d9daed7d

@monit-reviewer monit-reviewer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Review

Reviewed commit: 72963c4626bf
Profile: claude-monit-reviewer - Posting as: monit-reviewer

Summary

Reviewer Findings
harness-engineering:repo-health 0
policies:conventions 0
automation:ci-deploy 0
security:code-auditor 0

Reviewer Coverage

Complete coverage details are retained in the local coverage.json artifact.

  • harness-engineering:repo-health — complete (constrained); scope: 3 files; examples: .github/workflows/arch-package.yml, .github/workflows/release-build-check.yml, .goreleaser.yml; body-inspected: 3 files; examples: .github/workflows/arch-package.yml, .github/workflows/release-build-check.yml, .goreleaser.yml; skipped: none; constraints: Did not execute goreleaser; relied on the PR's stated verification and static inspection of the diff. Repo has no repo-local review guidance (.codereview/agents missing).
  • policies:conventions — complete (constrained); scope: 3 files; examples: .github/workflows/arch-package.yml, .github/workflows/release-build-check.yml, .goreleaser.yml; body-inspected: 3 files; examples: .github/workflows/arch-package.yml, .github/workflows/release-build-check.yml, .goreleaser.yml; skipped: none; constraints: Did not run goreleaser; relied on PR description for verification claims. No repo-local .codereview guidance on base branch; reviewed against Monit-wide conventions only.
  • automation:ci-deploy — complete (broad); scope: 3 files; examples: .github/workflows/arch-package.yml, .github/workflows/release-build-check.yml, .goreleaser.yml; body-inspected: 3 files; examples: .github/workflows/arch-package.yml, .github/workflows/release-build-check.yml, .goreleaser.yml; skipped: none; constraints: Static diff review only; goreleaser check/snapshot render not executed. Shared release workflow in SignalFT/github-workflows not inspected.
  • security:code-auditor — complete (constrained); scope: 1 file; examples: .goreleaser.yml; body-inspected: 1 file; examples: .goreleaser.yml; skipped: none; constraints: Did not run goreleaser; rendered cask output (postflight_steps) was not verified locally and relies on the PR description's claims. Review limited to the single changed file .goreleaser.yml.

0 PR discussion threads considered. 0 summarized; 0 resolved.


Completed in 1m 28s | ~$0.34 (est.) | claude-sonnet-5-5 | cr 0.10.351
Field Value
Model claude-sonnet-5-5
Reviewers harness-engineering:repo-health, policies:conventions, automation:ci-deploy, security:code-auditor
Engine claude_cli · claude-sonnet-5-5
Reviewed by cr · monit-reviewer
Duration 1m 28s wall · 2m 50s compute
Cost ~$0.34 (est.)
Pricing basis baseline-2026-10-02/pricing
Tokens 44 in / 5.6k out

Per-workstream usage

  • orchestrator-selection — claude-sonnet-5-5
    • In: 6
    • Out: 1.1k
    • Cache read: 22.2k
    • Cache create: 10.0k
    • Cost: ~$0.06 (est.)
    • Duration: 24s
  • harness-engineering:repo-health — claude-sonnet-5-5
    • In: 8
    • Out: 1.0k
    • Cache read: 42.5k
    • Cache create: 11.6k
    • Cost: ~$0.07 (est.)
    • Duration: 26s
  • policies:conventions — claude-sonnet-5-5
    • In: 8
    • Out: 981
    • Cache read: 42.1k
    • Cache create: 11.3k
    • Cost: ~$0.06 (est.)
    • Duration: 32s
  • automation:ci-deploy — claude-sonnet-5-5
    • In: 8
    • Out: 1.1k
    • Cache read: 45.2k
    • Cache create: 13.0k
    • Cost: ~$0.07 (est.)
    • Duration: 37s
  • security:code-auditor — claude-sonnet-5-5
    • In: 8
    • Out: 1.0k
    • Cache read: 41.9k
    • Cache create: 11.2k
    • Cost: ~$0.06 (est.)
    • Duration: 34s
  • orchestrator-rollup — claude-sonnet-5-5
    • In: 6
    • Out: 443
    • Cache read: 42.8k
    • Cache create: 2.4k
    • Cost: ~$0.02 (est.)
    • Duration: 15s

@piekstra
piekstra marked this pull request as ready for review October 28, 2026 14:11
@piekstra
piekstra merged commit a7e8e77 into main Oct 28, 2026
11 checks passed
@piekstra
piekstra deleted the piekstra/cask-install-steps branch October 28, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants