Skip to content

fix(release): write the cask postflight as install steps - #56

Merged
piekstra merged 1 commit into
mainfrom
piekstra/cask-install-steps
Oct 28, 2026
Merged

piekstra merged 1 commit into
mainfrom
piekstra/cask-install-steps

Conversation

@piekstra

Copy link
Copy Markdown
Member

Summary

The release workflow installs GoReleaser ~> v2, which now resolves to 2.19. That version deprecates homebrew_casks.hooks.post.install, and the workflow's goreleaser check fails on any deprecated property, so the next release would fail before building.

  • The cask postflight moves to install_steps with {{ .StagedPath }}. GoReleaser renders it as a postflight_steps block with the absolute {{staged_path}} token, which the shared alias job's modernizer passes through unchanged.
  • The previous step passed the binary as a relative argument with base: :staged_path. base: resolves only the command path, not arguments, so the argument is now the absolute staged path, matching the other casks in the tap.
  • GoReleaser pins in workflows move to v2.19.0, which reads install_steps.

Verification

  • goreleaser check with 2.19.0 passes for .goreleaser.yml; on main it fails with the deprecation.
  • goreleaser release --snapshot --clean --skip=publish,before,sign,validate renders each cask's postflight_steps block as run "/usr/bin/xattr", args: ["-dr", "com.apple.quarantine", "{{staged_path}}/<binary>"].

Model: Claude Opus 5.5 (1M context, xhigh effort) in Claude Code.

The release workflow installs GoReleaser `~> v2`, which now resolves to
2.19. That version deprecates `homebrew_casks.hooks.post.install`, and the
workflow's `goreleaser check` fails on any deprecated property, so the
next release would fail before building.

Move the postflight to `install_steps` with `{{ .StagedPath }}`.
GoReleaser renders it as a `postflight_steps` block with the absolute
`{{staged_path}}` token, which the shared modernizer passes through
unchanged. GoReleaser pins in workflows move to v2.19.0, which reads
`install_steps`.

Twapp-Session: f18916e9-4ebc-4371-a3db-eb58d9daed7d

@monit-reviewer monit-reviewer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Review

Reviewed commit: d6a8f436dcdf
Profile: claude-monit-reviewer - Posting as: monit-reviewer

Summary

Reviewer Findings
automation:ci-release 0
policies:conventions 0
harness-engineering:repo-health 0
automation:ci-deploy 0

Reviewer Coverage

Complete coverage details are retained in the local coverage.json artifact.

  • automation:ci-release — complete (broad); scope: 2 files; examples: .github/workflows/arch-package.yml, .goreleaser.yml; body-inspected: 2 files; examples: .github/workflows/arch-package.yml, .goreleaser.yml; skipped: none; context (not coverage): 1 file; examples: .github/workflows/release.yml; constraints: Did not run goreleaser; static review of the diff only. release.yml (unchanged, uses version '~> v2') was read as context only and is outside the assigned scope.
  • policies:conventions — complete (broad); scope: 2 files; examples: .github/workflows/arch-package.yml, .goreleaser.yml; body-inspected: 2 files; examples: .github/workflows/arch-package.yml, .goreleaser.yml; skipped: none; constraints: Shared cli-common docs and sibling tap casks were not available, so consistency with other casks relies on the PR description. release.yml uses '~> v2' (unchanged), which already resolves to a version that reads install_steps.
  • harness-engineering:repo-health — complete (constrained); scope: 2 files; examples: .github/workflows/arch-package.yml, .goreleaser.yml; body-inspected: 2 files; examples: .github/workflows/arch-package.yml, .goreleaser.yml; skipped: none; context (not coverage): 1 file; examples: .github/workflows/release.yml; constraints: Did not run goreleaser; relied on the diff and PR description for the install_steps rendering behavior. release.yml uses a floating '~> v2' pin while arch-package.yml pins v2.19.0; this is pre-existing and not worsened by the diff.
  • automation:ci-deploy — complete (broad); scope: 1 file; examples: .github/workflows/arch-package.yml; body-inspected: 1 file; examples: .github/workflows/arch-package.yml; skipped: none; constraints: Inspected the pinned-head body of the assigned workflow file only; did not run goreleaser or view the diff against base, and did not inspect .goreleaser.yml or release workflow (out of assigned scope).

0 PR discussion threads considered. 0 summarized; 0 resolved.


Completed in 3m 44s | $0.37 | claude-sonnet-5-5 | cr 0.10.351
Field Value
Model claude-sonnet-5-5
Reviewers automation:ci-release, policies:conventions, harness-engineering:repo-health, automation:ci-deploy
Engine claude_cli · claude-sonnet-5-5
Reviewed by cr · monit-reviewer
Duration 3m 44s wall · 4m 14s compute
Cost $0.37
Tokens 52 in / 7.2k out

Per-workstream usage

  • orchestrator-selection — claude-sonnet-5-5
    • In: 6
    • Out: 1.3k
    • Cache read: 23.7k
    • Cache create: 11.8k
    • Cost: ~$0.07 (est.)
    • Duration: 24s
  • automation:ci-release — claude-sonnet-5-5
    • In: 10
    • Out: 1.6k
    • Cache read: 56.1k
    • Cache create: 11.4k
    • Cost: ~$0.07 (est.)
    • Duration: 1m 13s
  • policies:conventions — claude-sonnet-5-5
    • In: 10
    • Out: 1.3k
    • Cache read: 55.3k
    • Cache create: 11.1k
    • Cost: ~$0.07 (est.)
    • Duration: 1m 03s
  • harness-engineering:repo-health — claude-sonnet-5-5
    • In: 10
    • Out: 1.4k
    • Cache read: 58.5k
    • Cache create: 12.0k
    • Cost: ~$0.07 (est.)
    • Duration: 48s
  • automation:ci-deploy — claude-sonnet-5-5
    • In: 10
    • Out: 1.2k
    • Cache read: 52.4k
    • Cache create: 11.8k
    • Cost: $0.06
    • Duration: 27s
  • orchestrator-rollup — claude-sonnet-5-5
    • In: 6
    • Out: 402
    • Cache read: 48.2k
    • Cache create: 2.5k
    • Cost: ~$0.02 (est.)
    • Duration: 16s

@piekstra
piekstra marked this pull request as ready for review October 28, 2026 14:11
@piekstra
piekstra merged commit a6610d9 into main Oct 28, 2026
5 checks passed
@piekstra
piekstra deleted the piekstra/cask-install-steps branch October 28, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants