Repository navigation
fix(release): write the cask postflight as install steps - #47
Merged
Merged
Conversation
The release workflow installs GoReleaser `~> v2`, which now resolves to
2.19. That version deprecates `homebrew_casks.hooks.post.install`, and the
workflow's `goreleaser check` fails on any deprecated property, so the
next release would fail before building.
Move the postflight to `install_steps` with `{{ .StagedPath }}`.
GoReleaser renders it as a `postflight_steps` block with the absolute
`{{staged_path}}` token, which the shared modernizer passes through
unchanged. GoReleaser pins in workflows move to v2.19.0, which reads
`install_steps`.
Twapp-Session: f18916e9-4ebc-4371-a3db-eb58d9daed7d
PR BuildVersion:
Built from e6796c4 |
monit-reviewer
approved these changes
Oct 28, 2026
monit-reviewer
left a comment
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: e6796c4ab70d
Profile: claude-monit-reviewer - Posting as: monit-reviewer
Summary
| Reviewer | Findings |
|---|---|
| automation:ci-release | 0 |
| harness-engineering:repo-health | 0 |
| policies:conventions | 0 |
Reviewer Coverage
Complete coverage details are retained in the local coverage.json artifact.
automation:ci-release— complete (broad); scope: 2 files; examples:.github/workflows/arch-package.yml,.goreleaser.yml; body-inspected: 2 files; examples:.github/workflows/arch-package.yml,.goreleaser.yml; skipped: none; context (not coverage): 2 files; examples:.github/workflows/pr-artifacts.yml,.github/workflows/release.yml; constraints: Could not run goreleaser check or snapshot release; relied on static diff inspection and PR description. release.yml and pr-artifacts.yml use goreleaser version: latest (not pinned), so they pick up install_steps without changes; not in assigned scope.harness-engineering:repo-health— complete (constrained); scope: 2 files; examples:.github/workflows/arch-package.yml,.goreleaser.yml; body-inspected: 2 files; examples:.github/workflows/arch-package.yml,.goreleaser.yml; skipped: none; context (not coverage): 2 files; examples:.github/workflows/pr-artifacts.yml,.github/workflows/release.yml; constraints: Static review only; goreleaser check and snapshot rendering were not executed. release.yml and pr-artifacts.yml use goreleaser version 'latest' (unchanged, out of scope), so only arch-package.yml carries a pin to bump.policies:conventions— complete (broad); scope: 2 files; examples:.github/workflows/arch-package.yml,.goreleaser.yml; body-inspected: 2 files; examples:.github/workflows/arch-package.yml,.goreleaser.yml; skipped: none; constraints: Could not run goreleaser check to confirm install_steps schema. Shared cli-common docs and tap conventions were not available in context; review limited to the diff and repo checkout.
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 2m 04s | ~$0.27 (est.) | claude-sonnet-5-5 | cr 0.10.351
| Field | Value |
|---|---|
| Model | claude-sonnet-5-5 |
| Reviewers | automation:ci-release, harness-engineering:repo-health, policies:conventions |
| Engine | claude_cli · claude-sonnet-5-5 |
| Reviewed by | cr · monit-reviewer |
| Duration | 2m 04s wall · 2m 31s compute |
| Cost | ~$0.27 (est.) |
| Pricing basis | baseline-2026-10-02/pricing |
| Tokens | 36 in / 4.9k out |
Per-workstream usage
orchestrator-selection— claude-sonnet-5-5- In: 6
- Out: 1.2k
- Cache read: 23.7k
- Cache create: 11.7k
- Cost: ~$0.06 (est.)
- Duration: 25s
automation:ci-release— claude-sonnet-5-5- In: 8
- Out: 1.1k
- Cache read: 41.3k
- Cache create: 11.2k
- Cost: ~$0.06 (est.)
- Duration: 35s
harness-engineering:repo-health— claude-sonnet-5-5- In: 10
- Out: 1.3k
- Cache read: 58.2k
- Cache create: 11.8k
- Cost: ~$0.07 (est.)
- Duration: 39s
policies:conventions— claude-sonnet-5-5- In: 6
- Out: 798
- Cache read: 25.7k
- Cache create: 9.2k
- Cost: ~$0.05 (est.)
- Duration: 34s
orchestrator-rollup— claude-sonnet-5-5- In: 6
- Out: 413
- Cache read: 47.8k
- Cache create: 2.4k
- Cost: ~$0.02 (est.)
- Duration: 17s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release workflow installs GoReleaser
~> v2, which now resolves to 2.19. That version deprecateshomebrew_casks.hooks.post.install, and the workflow'sgoreleaser checkfails on any deprecated property, so the next release would fail before building.install_stepswith{{ .StagedPath }}. GoReleaser renders it as apostflight_stepsblock with the absolute{{staged_path}}token, which the shared alias job's modernizer passes through unchanged.base: :staged_path.base:resolves only the command path, not arguments, so the argument is now the absolute staged path, matching the other casks in the tap.install_steps.Verification
goreleaser checkwith 2.19.0 passes for.goreleaser.yml; onmainit fails with the deprecation.goreleaser release --snapshot --clean --skip=publish,before,sign,validaterenders each cask'spostflight_stepsblock asrun "/usr/bin/xattr", args: ["-dr", "com.apple.quarantine", "{{staged_path}}/<binary>"].Model: Claude Opus 5.5 (1M context, xhigh effort) in Claude Code.