Conversation
Complete-CiMapWorkloads threw when the manifest named an ordinary shard the certified map had never measured. Selection caught that and ran the full matrix, so every pull request escalated from the moment a shard was added until a new map was certified - and certification replays through the same function, so the map could not catch up. The manifest grew 116 -> 209 between 2026-09-15 and 09-17 and no pull request reduced. An unmeasured workload now joins alwaysRun, exactly as auxiliary workloads already did: it runs on every selection until a map includes it, and no coverage is invented for it. Malformed kinds and shards the manifest no longer has are still rejected. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedNext included review available in 37 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every pull request has run the full matrix (209 shards) since #2173 merged, with:
Complete-CiMapWorkloadsthrew whenever the manifest named an ordinary shard the certified map had never measured. Selection caught the throw and escalated the whole PR. The nightly certification replays through the same function, so the map could not catch up either. The manifest grew 116 → 161 → 164 → 209 between 09-15 and 09-17.Measured over 71 PR runs since 09-08: 13 reduced, and 7 of those were canary/proof branches. Since 09-16, every PR that reached a decision escalated.
Change
An unmeasured workload of any kind now joins
alwaysRun: it runs on every selection until a map includes it, and no coverage is invented for it. Auxiliary workloads were already handled this way, andSelect-Shards.ps1already hadAdd-UnmappedShardsAsAlwaysRunfor the same purpose. The throw pre-empted it. Malformed kinds and map shards the manifest no longer has are still rejected.Evidence (production data, not fixtures)
The selector was replayed inside each PR's GitHub merge ref, using that tree's own
test-shards.ymland the certified map CI uses today (run 35047041346, 116 shards). Arms were master'stools/TestImpactversus this branch's.The master arm reproduces the production message exactly.
Test-CiWorkloads.ps1fails on master'sCiWorkloadKinds.ps1and passes here.Select-Shards -SelfTest,Test-TestImpactEndToEnd,Test-CiImpactWorkflow,Test-CiPolicyImpact,Test-AuxiliaryInventory,Test-AuxiliaryEvidenceandTest-CiGateModespass locally.Not fixed here
The 96 always-run shards are the cost of a map that predates them. They leave only when a map is certified on the current manifest. The nightly harvest still rejects any coverage run whose shard list differs from master's (
used a different shard manifest), so onetest-shards.ymledit during the ~24-hour dispatch-and-harvest window delays the map another day. A follow-up PR makes the harvest accept per-shard-unchanged coverage.This PR changes selection tooling, so its own run escalates to the full matrix by design.
🤖 Generated with Claude Code