Skip to content

Optimize UPF E2E image builds - #1302

Open
andybavier wants to merge 2 commits into
mainfrom
codex/optimize-upf-e2e-images
Open

andybavier wants to merge 2 commits into
mainfrom
codex/optimize-upf-e2e-images

Conversation

@andybavier

@andybavier andybavier commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Address #1301 by avoiding the BESS image rebuild when a UPF pull request cannot affect BESS.

  • Extends the existing pinned dorny/paths-filter job with an E2E-specific BESS-impact filter.
  • Selects bess pfcp when the PR changes bess/, conf/, Dockerfile, .dockerignore, or requirements.txt.
  • Otherwise selects pfcp, so the reusable workflow builds, deploys, and verifies only localhost:5000/pfcp:testing; the chart keeps its released BESS image.
  • Pins the backward-compatible image_list input from the released shared workflow v0.0.32 at commit d57b6360a2cc92237c201f2bb9ad58b924ef7082.

The PFCP Docker target does not depend on the BESS build stage, so the PFCP-only path avoids the ~13-minute BESS compilation rather than merely omitting the BESS output.

Validation

  • Parsed .github/workflows/main.yml with PyYAML.
  • git diff --check.
  • The earlier PR run exercised the PFCP-only path successfully; this update changes only the shared-workflow reference from its tested PR commit to the v0.0.32 release commit.
  • actionlint reports only three existing unsupported permission scopes outside this change.

@andybavier
andybavier requested a review from a team September 16, 2026 18:35
Signed-off-by: Andy Bavier <andybavier@gmail.com>
Signed-off-by: Andy Bavier <andybavier@gmail.com>
@gab-arrobo
gab-arrobo force-pushed the codex/optimize-upf-e2e-images branch from 6038329 to 1124422 Compare September 16, 2026 20:08
- 'bess/**'
- 'conf/**'
- 'Dockerfile'
- '.dockerignore'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is .dockerignore included in this list?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thinking is that a change to .dockerignore can change the Docker build context, so build both images to be safe.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

Pull request overview

Optimizes UPF pull-request E2E builds by rebuilding BESS only when relevant files change.

Changes:

  • Adds a BESS-impact path filter.
  • Selects bess pfcp or pfcp for E2E workflows.
  • Pins the reusable workflow to v0.0.32.
File summaries
File Description
.github/workflows/main.yml Adds path-based E2E image selection and reusable workflow input.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants