Optimize UPF E2E image builds - #1302
Open
andybavier wants to merge 2 commits into
Open
andybavier wants to merge 2 commits into
andybavier wants to merge 2 commits into
Conversation
Signed-off-by: Andy Bavier <andybavier@gmail.com>
Signed-off-by: Andy Bavier <andybavier@gmail.com>
gab-arrobo
force-pushed
the
codex/optimize-upf-e2e-images
branch
from
September 16, 2026 20:08
6038329 to
1124422
Compare
gab-arrobo
reviewed
Sep 16, 2026
| - 'bess/**' | ||
| - 'conf/**' | ||
| - 'Dockerfile' | ||
| - '.dockerignore' |
Contributor
There was a problem hiding this comment.
Why is .dockerignore included in this list?
Contributor
Author
There was a problem hiding this comment.
The thinking is that a change to .dockerignore can change the Docker build context, so build both images to be safe.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Optimizes UPF pull-request E2E builds by rebuilding BESS only when relevant files change.
Changes:
- Adds a BESS-impact path filter.
- Selects
bess pfcporpfcpfor E2E workflows. - Pins the reusable workflow to v0.0.32.
File summaries
| File | Description |
|---|---|
.github/workflows/main.yml |
Adds path-based E2E image selection and reusable workflow input. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address #1301 by avoiding the BESS image rebuild when a UPF pull request cannot affect BESS.
The PFCP Docker target does not depend on the BESS build stage, so the PFCP-only path avoids the ~13-minute BESS compilation rather than merely omitting the BESS output.
Validation