Skip to content

[DVOPS-382] Structure dependency wait script logs - #3755

Merged
vigneshhari merged 1 commit into
ohcnetwork:developfrom
jesbinjoseph:jesbinjoseph-dependency-check-output
Sep 8, 2026
Merged

[DVOPS-382] Structure dependency wait script logs#3755
vigneshhari merged 1 commit into
ohcnetwork:developfrom
jesbinjoseph:jesbinjoseph-dependency-check-output

Conversation

@jesbinjoseph

@jesbinjoseph jesbinjoseph commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add timestamped, leveled logging to the PostgreSQL and Redis wait scripts
  • send waiting and availability messages to stdout
  • keep exhausted-retry failures on stderr

Validation

  • validated both scripts with bash -n
  • checked both scripts with ShellCheck when available

Summary by CodeRabbit

  • Improvements
    • Improved database and cache startup logs with timestamps and script labels.
    • Clarified retry, waiting, failure, and success messages for easier troubleshooting.
    • Distinguished informational messages from errors through appropriate output channels.

@jesbinjoseph
jesbinjoseph requested a review from a team as a code owner September 8, 2026 11:11
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: de1ad04e-9827-4aac-9ff8-18ddc3b29a8c

📥 Commits

Reviewing files that changed from the base of the PR and between a90aa59 and 54b1aae.

📒 Files selected for processing (2)
  • scripts/wait_for_db.sh
  • scripts/wait_for_redis.sh

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The PostgreSQL and Redis wait scripts add timestamped, script-prefixed logging helpers. Retry-loop messages now use informational or error output while preserving retry behavior.

Changes

Startup script logging

Layer / File(s) Summary
Timestamped logging helpers
scripts/wait_for_db.sh, scripts/wait_for_redis.sh
Both scripts define log_info and log_error helpers with timestamped, script-prefixed output.
Retry-loop logging integration
scripts/wait_for_db.sh, scripts/wait_for_redis.sh
Retry messages use the new helpers. Retry counting, delays, and exit behavior remain unchanged. Redis success messages now use stdout.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 54b1a

PostgreSQL and Redis dependency waits now emit timestamped, leveled logs with normal progress on stdout and exhausted retries on stderr. Retry behavior is unchanged, and no current merge-blocking risk remains.

Suggested reviewers: vigneshhari

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description clearly explains the logging changes and validation steps. It does not include the template headings for the associated issue, architecture changes, or merge checklist, but the main re…
Title check ✅ Passed The title clearly identifies the main change: structuring dependency wait script logs. The issue reference is concise and relevant.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.74%. Comparing base (a90aa59) to head (54b1aae).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3755   +/-   ##
========================================
  Coverage    79.74%   79.74%           
========================================
  Files          482      482           
  Lines        23297    23297           
  Branches      2424     2424           
========================================
  Hits         18579    18579           
  Misses        4115     4115           
  Partials       603      603           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jesbinjoseph jesbinjoseph changed the title Structure dependency wait script logs [DVOPS-382] Structure dependency wait script logs Sep 8, 2026
@vigneshhari
vigneshhari merged commit a749b92 into ohcnetwork:develop Sep 8, 2026
6 of 9 checks passed
@jesbinjoseph
jesbinjoseph deleted the jesbinjoseph-dependency-check-output branch September 9, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants