Repository navigation
Conversation
Contributor
Author
|
@yegor256 CI is green and the branch is up to date with |
…r in incorrect-test-object-name
sherenkov
force-pushed
the
bug/#1692/test-object-name-title
branch
from
November 12, 2026 00:42
3ec1793 to
3ae274a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
incorrect-test-object-namechecked the title of a unit test,eo:test-title(@name), against its regular expression, but printed the raw@namein the defect message. So[] +> test_abcwas reported asThe name of the object "+test_abc" doesn't match ..., and as"p🌵test_abc"with a parser that marks tests withp🌵/n🌵.The message now prints the title through
eo:test-title, asbad-test-name,wrong-test-orderandunit-test-without-phialready do, so it readsThe name of the object "test_abc" doesn't match ....New packs in
packs/single/incorrect-test-object-name/assert the text of the message, which no pack did before:prints-title-of-truthy-test.yaml:[] +> test_abcin EO;prints-title-of-throwing-test.yaml:[] -> throws_when_emptyin EO;prints-title-of-cactus-marked-test.yaml:p🌵test_abcandn🌵throws_when_emptyin XMIR, since the pinned parser still emits+/-.All three fail on
masterand pass with the change, and each still expects exactly one warning per misnamed test on its line. The other packs of the lint,catches-*andallows-*, pass unchanged.Closes #1692.