Repository navigation
Add special note for when files are too large to export - #389
Merged
Merged
Conversation
rshorey
approved these changes
Nov 20, 2025
rshorey
left a comment
rshorey
left a comment
There was a problem hiding this comment.
might want to make a small change but if you do just go ahead and merge after
| heading: Uh oh, that's a 500. | ||
| message: Perhaps try to search for something else instead? | ||
| sizeLimitNote: | ||
| message: "The document is too large to display in Library. We are working on a fix, but in the meantime, you can view the document directly in Google Drive." |
There was a problem hiding this comment.
should we say "the document may be..." instead of "the document is..." in case all of doctools is down somehow?
Member
Author
There was a problem hiding this comment.
This will only show in the case that google specifically sends us the exportSizeLimitExceeded error, so I think ok to keep it as "is."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds a customizable message for when a page 500s due to a file being too large to export.
Related Issue
#388
Motivation and Context
This has been confusing for users, and will hopefully reduce support burden for those supporting Library as we work on fixing the issue.
Checklist
npm run lintand updated code style accordinglynpm run testpasses