Skip to content

How to deploy customization forks #79

Closed

Description

@palewire

I've successfully deployed the standard app to Heroku. Everything is a-okay. Now I want to begin to customize the vanilla deploy.

When I first created the Heroku app with the magic button, I input a CUSTOMIZATION_GIT_REPO variable that points to git@github.com:datadesk/library-customization.git, where I have forked the example customization library.

My hope is that I can simply push changes to my fork and somehow trigger them to build on Heroku, but it's unclear to me from the docs how to make this happen. Anyone have advice?

Activity

  1. added
    questionFurther information is requested
    and removed
    bugSomething isn't working
    on Nov 11, 2019
  2. isaacwhite commented on Nov 11, 2019

    @isaacwhite
    Member

    Hey @palewire, we still deploy our customized Heroku sites manually using the cli integration. You should be able to do that by following the general Heroku CLI docs.

    You might be able to use a GitHub integration hook to autodeploy your Library site, but my hunch is that the deploys in that case would be triggered by pushes to the main nytimes/library repo, which is not what you want.

    I think it would be possible to flip the current Procfile integration, so that the customization repo clones in nytimes/library on each deploy and moves the overrides accordingly. If the customization repo had a Procfile like that, customized autodeploys would probably fit the typical Heroku integration pattern better. Is that something you'd be interested in exploring?

  3. palewire commented on Nov 11, 2019

    @palewire
    ContributorAuthor

    Not to give you even more to do, but the ideal integration from my point of view would let me push to my customization repo and have it autodeploy to Heroku. That way I'd only need that slimmed down config repository to make things go.

  4. maxine commented on Nov 11, 2019

    @maxine
    Contributor

    @palewire great idea - want to open a new feature request issue for this enhancement?

  5. afischer commented on May 25, 2021

    @afischer
    Member

    Due to the topic of this issue, it is being converted into a discussion! This issue will be closed, but discussion can continue in the newly created discussion.

  6. locked and limited conversation to collaborators on May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions