Conversation
shuangwu
marked this pull request as ready for review
September 18, 2026 13:58
shuangwu
marked this pull request as draft
September 19, 2026 04:32
shuangwu
marked this pull request as ready for review
September 19, 2026 05:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness
Ready for review. Full-job GPU validation covers colocated RL and two-replica SFT, including stopping during active validation and injected final-checkpoint failure. Full CI is still required before merge.
Summary
Add controller-owned
await controller.request_stop(reason)for successful early completion across disaggregated RL, colocated RL (including colocated-separated execution), and single-/multi-replica SFT.Includes the controller API, HTTP forwarding for colocated facades, documentation, regression tests, and portable validation/failure-injection fixtures.
Validation
PYTHONPATH=. torchrun --standalone --nproc-per-node=2 tests/generic_stop_rank_canary.py.tests/requested_stop_sft_live.py,tests/requested_stop_canary.py, andtests/configs/requested_stop_colocated.toml; reproduction and required assertions are indocs/requested_stop.md. The SFT fixture generates a tiny local model and dataset and uses the real checkpoint saver. The colocated fixture uses the companion custom trainer and test-only checkpoint format.Scope and independence
Based directly on upstream main. Does not contain or replace #747. The new colocated and SFT live canaries ran without #747. Prior disaggregated failure-containment validation used a separate combined snapshot with an earlier #747 implementation; it does not establish behavior for redesigned #747.
The live cases do not establish multi-node, sharded-model, or colocated-separated lifecycle coverage. A missing participant or stalled collective cannot be reported as successful completion. This change adds no scheduler-wide failure propagation or recovery guarantee; use a finite outer job limit.