Drop TLS key config - #4131
Merged
Merged
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
August 14, 2026 11:52
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4131 +/- ##
==========================================
+ Coverage 27.15% 27.16% +0.01%
==========================================
Files 679 679
Lines 46206 46203 -3
==========================================
+ Hits 12546 12552 +6
+ Misses 32474 32463 -11
- Partials 1186 1188 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
roman-khimov
left a comment
roman-khimov
left a comment
Member
There was a problem hiding this comment.
Nothing criticall, but conflicts.
End-rey
force-pushed
the
drop-tls-cert-config
branch
2 times, most recently
from
August 17, 2026 09:48
218e917 to
54e1c2a
Compare
roman-khimov
approved these changes
Aug 17, 2026
Member
|
@End-rey, can you fix testcases to omit key configuration for 0.55.0+? |
End-rey
force-pushed
the
drop-tls-cert-config
branch
from
August 18, 2026 10:29
54e1c2a to
c3b2f7d
Compare
Use the node wallet key for TLS handshakes and verify that the configured certificate matches it. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
force-pushed
the
drop-tls-cert-config
branch
from
August 18, 2026 10:36
c3b2f7d to
00dbe4d
Compare
The TLS private key is already available from the node wallet. Closes #4117. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4117.