Skip to content

fix(exec): don't inherit global config when installing to the npx cache #9894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lazerg wants to merge 2 commits into
base: latest
Choose a base branch
from
+32 −0
Open

fix(exec): don't inherit global config when installing to the npx cache #9894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75f2de8
fix(exec): don't inherit global config when installing to the npx cache
lazerg Aug 18, 2026
56a2bf8
chore(exec): assert npx cache bins are not linked globally
lazerg Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions workspaces/libnpmexec/lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ const exec = async (opts) => {
const npxArb = new Arborist({
...flatOptions,
path: installDir,
global: false,
})
const lockPath = join(installDir, 'concurrency.lock')
const npxTree = await withLock(lockPath, () => npxArb.loadActual())
Expand Down
31 changes: 31 additions & 0 deletions workspaces/libnpmexec/test/registry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,3 +328,34 @@ t.test('override save to true when installing to npx cache', async t => {
value: 'packages-2.0.0',
})
})

t.test('ignore inherited global config when installing to npx cache', async t => {
const { fixtures, package } = createPkg({ versions: ['2.0.0'] })

const hash = crypto.createHash('sha512')
.update('@npmcli/create-index')
.digest('hex')
.slice(0, 16)

const { exec, path, registry, readOutput } = setup(t, {
testdir: merge(fixtures, {
global: {},
}),
})

await package({ registry, path })

await exec({
args: ['@npmcli/create-index'],
globalPath: resolve(path, 'global'),
global: true,
})

const binPath = resolve(path, 'npxCache', hash, 'node_modules', '.bin')
t.ok(existsSync(binPath), 'bins should be linked at npxCache')
t.notOk(existsSync(resolve(path, 'npxCache', 'bin')), 'bins should not be linked globally')

t.match(await readOutput('@npmcli-create-index'), {
value: 'packages-2.0.0',
})
})
Loading