Skip to content

ci: lint workflow files via non7top/gh-workflows' shared actions-lint - #39

Merged
non7top merged 1 commit into
masterfrom
feat/actions-lint
Sep 26, 2026
Merged

non7top merged 1 commit into
masterfrom
feat/actions-lint

Conversation

@non7top

@non7top non7top commented Sep 26, 2026

Copy link
Copy Markdown
Owner

Depends on non7top/gh-workflows#3 (the reusable workflow this calls —
merge that first, or this job fails to resolve @main until it lands).

actionlint + check-jsonschema, sourced from gh-workflows rather than a
locally-pinned copy, gated on PRs that touch .github/workflows/**.
Catches same-repo authoring mistakes before merge — bad expressions,
malformed YAML, a bad input to a local reusable-workflow reference.

Doesn't catch the specific mistake from #38's package-name follow-up
(non7top/gh-workflows#2): actionlint can't validate a with: block
against a reusable workflow defined in another repo, so an undeclared
input on release-please-preview.yml's own call into gh-workflows would
still sail through clean. That gap is still open — tracked there.

Verified both tools run clean against this repo's current workflow files
in disposable containers before pushing.

actionlint + check-jsonschema, sourced from non7top/gh-workflows#3 rather
than a locally-pinned copy, gated on PRs that touch .github/workflows/**.
Catches same-repo authoring mistakes (bad expressions, malformed YAML, a
bad input to a local reusable-workflow reference) before merge.

Doesn't catch the specific mistake from #38's package-name follow-up
(non7top/gh-workflows#2): actionlint can't validate a `with:` block
against a reusable workflow defined in another repo, so an undeclared
input on release-please-preview.yml's own call into gh-workflows would
still sail through clean. That gap is still open.

Verified both tools run clean against this repo's current workflow files
in disposable containers before pushing.
@github-actions

Copy link
Copy Markdown
Contributor

🤖 release-please PREVIEW

What merging this PR into master would trigger:

🤖 I will create a release beep boop

0.5.0 (2026-09-26)

Bug Fixes

  • release: give each crate a literal version instead of workspace-inherited (bbe21e3)
  • release: give each crate a literal version instead of workspace-inherited (ceab4bc)
  • release: leave the literal versions at 0.1.0, not 0.5.0 (3ef4898)

Miscellaneous Chores


This PR was generated with Release Please. See documentation.

Predicted from 83e97f4 merged into master at bbe21e3, with the PR title read as ci: lint workflow files via non7top/gh-workflows' shared actions-lint · Full run

@github-actions

Copy link
Copy Markdown
Contributor

Windows build ready for cdc7626 (17.3 MB):

Download and run it. No unpacking, no installer, no runtime needed.

@non7top
non7top merged commit 11ae392 into master Sep 26, 2026
5 checks passed
@non7top
non7top deleted the feat/actions-lint branch September 26, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant