Skip to content

chore(docs): bump nominal-sphinx-theme to 2c17e21 - #678

Merged
arsenovicAtNominal merged 2 commits into
mainfrom
chore/bump-nominal-sphinx-theme
Oct 27, 2026
Merged

arsenovicAtNominal merged 2 commits into
mainfrom
chore/bump-nominal-sphinx-theme

Conversation

@arsenovicAtNominal

@arsenovicAtNominal arsenovicAtNominal commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Updates the locked nominal-sphinx-theme from 226bd86 to 2c17e21 (upstream main), which adds:

Only uv.lock changes. Besides the theme, the lock's versions of instro's own packages catch up with their pyproject.toml files (for example, instro 1.21.0 → 1.22.0), and the theme's myst-parser dependency is listed. Locked with uv 0.12.5, so the lock stays at revision 3.

Type of change

  • Chore / tooling (chore)

Verification

  • uv lock --check passes.
  • Strict docs build (just build-docs: sphinx-build -E -W) passes with the new theme, and the header has the Product Guides button.

Tests

  • No tests — explain why: only the docs theme's version changes; the docs build checks it.

Checklist

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Oct 27, 2026

Copy link
Copy Markdown

No reviewable files after applying ignore patterns.

@claude

claude Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @arsenovicAtNominal's task in 40s —— View job


Code Review

Overview: Clean, minimal lockfile-only change that follows the documented theme-bump procedure exactly (docs/AGENTS.md:30: change the theme upstream, then uv lock --upgrade-package nominal-sphinx-theme here). pyproject.toml pins the theme to the git URL without a rev (pyproject.toml:106), so the lock is the correct and only place this bump shows up — no pyproject.toml edit needed. The incidental instro/instro-unstable/etc. version bumps in the lock match their current pyproject.toml versions (verified instro 1.22.0 against root pyproject.toml:3), consistent with release-please-managed versions simply catching up. uv.lock stays at revision 3 as noted. No driver/API/docs-content changes are in scope, so none of the usual driver-convention, breaking-change, or docs-sync checks apply here.

No findings.

  • Gather context (PR diff, AGENTS.md conventions)
  • Review the uv.lock diff
  • Post findings
    (branch)

@arsenovicAtNominal
arsenovicAtNominal merged commit da8d019 into main Oct 27, 2026
18 checks passed
@arsenovicAtNominal
arsenovicAtNominal deleted the chore/bump-nominal-sphinx-theme branch October 27, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant