build: add --shared-abseil configure flag - #65682
Open
aduh95 wants to merge 3 commits into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65682 +/- ##
==========================================
- Coverage 90.07% 89.98% -0.09%
==========================================
Files 754 757 +3
Lines 256378 257376 +998
Branches 48498 48795 +297
==========================================
+ Hits 230936 231609 +673
- Misses 16572 16851 +279
- Partials 8870 8916 +46 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Changelog@@ -16,0 +17,8 @@
+/nix/store/y920274366mm39dly3ia2i3wsccpn51d-abseil-cpp-20260107.1 (aarch64-darwin)
+/nix/store/3qjql2462isf3jwsykmq1869dcq7y1ga-abseil-cpp-20260107.1 (aarch64-linux)
+/nix/store/g5bfb54qhcprz6fbwy6y0344gyhdq39n-abseil-cpp-20260107.1 (x86_64-darwin)
+/nix/store/l6gapc4fk3sk0jw4nl0a2vv5kg524pyp-abseil-cpp-20260107.1 (x86_64-linux)
+/nix/store/q72vmagbml3b8rz7l66msrll11p326jz-abseil-cpp-20260107.1-dev (aarch64-darwin)
+/nix/store/bx5779p5qm7jq21n7ikcwrmxz6zyln98-abseil-cpp-20260107.1-dev (aarch64-linux)
+/nix/store/s84wwacmp88nld1znzjkrn3s0gsg930c-abseil-cpp-20260107.1-dev (x86_64-darwin)
+/nix/store/ndpd5dd1gsza5mw34cy3024zfm28hds5-abseil-cpp-20260107.1-dev (x86_64-linux) |
legendecas
approved these changes
Sep 2, 2026
legendecas
added
the
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A requirement for #65614 (abseil is a requirement of both perfetto and V8, and it needs to be the same version)