http: match subdomains for plain NO_PROXY entries - #65617
Open
dibenkobit wants to merge 1 commit into
Open
Conversation
NO_PROXY=example.com only exact-matched the hostname in the http(s) builtins, so requests to subdomains still used the proxy. fetch() already matches the host and its subdomains. Reuse the existing suffix matcher (label boundary) for plain entries as well as leading-dot ones. Fixes: nodejs#65616 Assisted-by: Grok 4.6 Extra High Signed-off-by: Nikita Snetkov <lukyanish@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NO_PROXY=example.com only exact-matched the hostname in the
http(s) builtins, so requests to subdomains still used the proxy.
fetch() already matches the host and its subdomains.
Reuse the existing suffix matcher (label boundary) for plain
entries as well as leading-dot ones.
*.example.comis unchanged(subdomains only, not the apex).
Fixes: #65616
Refs: #57872
Assisted-by: Grok 4.6 Extra High
cc @nodejs/http
Made with Cursor