Skip to content

test: mark platform-specific tests as flaky - #65562

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:july-flakes
Aug 28, 2026
Merged

test: mark platform-specific tests as flaky#65562
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:july-flakes

Conversation

@panva

@panva panva commented Aug 26, 2026

Copy link
Copy Markdown
Member

These tests repeatedly failed across unrelated CI runs against main in the reliability reports from 2026-07-26 through 2026-08-26. Mark them flaky only on configurations where the failures were observed:

  • test-run-watch-cwd-isolation-none, test-run-watch-cwd-isolation-none-argv, and test-run-watch-emit-restarted on macOS x64
  • test-debugger-pid on Windows
  • test-runner-coverage on Windows, Linux s390x, and AIX
  • test-wasi-pthread on macOS and Windows

The report window was deduplicated by parent Jenkins job. Release-branch jobs were excluded. The single SmartOS watch timeout had a different signature and is not included.

Failures with opened fix PRs are also excluded (#65554, #65440, #65564).

Refs: #54534 (comment)
Refs: #63212 (comment)
Refs: #55154 (comment)
Refs: #64226 (comment)

Assisted-by: Codex

These tests repeatedly fail across unrelated `main` PRs in the
reliability reports from 2026-07-26 through 2026-08-26. Mark them
flaky only on configurations where the failures were observed.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva added flaky-test Issues and PRs involving tests that fail intermittently in CI. fast-track PRs proposed for a shorter-than-standard waiting period before landing. review wanted PRs that need review. labels Aug 26, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/wasi

@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 26, 2026
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (e7a69c4) to head (2d68563).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65562      +/-   ##
==========================================
- Coverage   90.08%   90.07%   -0.02%     
==========================================
  Files         751      751              
  Lines      254075   254420     +345     
  Branches    47910    47977      +67     
==========================================
+ Hits       228882   229166     +284     
- Misses      16412    16430      +18     
- Partials     8781     8824      +43     

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Hardanish-Singh Hardanish-Singh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2026
@nodejs-github-bot

This comment was marked as outdated.

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2026
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 27, 2026
@nodejs-github-bot
nodejs-github-bot merged commit e5a1ce2 into nodejs:main Aug 28, 2026
101 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in e5a1ce2

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 28, 2026
@panva
panva deleted the july-flakes branch August 28, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. review wanted PRs that need review. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants