crypto: add a generic MAC API - #65553
Draft
panva wants to merge 1 commit into
Draft
Conversation
Add getMacs() and createMac() to node:crypto as a layer on top of OpenSSL EVP_MAC. Support incremental and streaming operations with provider parameter validation and configurable output sizes. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
jasnell
reviewed
Aug 26, 2026
| CHECK_NOT_NULL(cache); | ||
| if (!algorithm_cache.IsEmpty()) { | ||
| Isolate* isolate = env->isolate(); | ||
| Local<Context> context = isolate->GetCurrentContext(); |
Member
There was a problem hiding this comment.
Suggested change
| Local<Context> context = isolate->GetCurrentContext(); | |
| Local<Context> context = env->context(); |
jasnell
approved these changes
Aug 26, 2026
jasnell
added
the
semver-minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add getMacs() and createMac() to node:crypto as a layer on top of OpenSSL EVP_MAC. Support incremental and streaming operations with provider parameter validation and configurable output sizes.
TODO
Refs: #32433
Refs: #48314
Refs: #32448
Refs: #32477