net: fix BlockList.fromJSON for IPv4-mapped IPv6 rules - #64125
Open
watilde wants to merge 1 commit into
Open
Conversation
watilde
added
request-ci
Collaborator
Member
|
@watilde ... can I ask you to rebase this so we can get it landed :-) |
jasnell
approved these changes
Aug 29, 2026
BlockList.toJSON() serializes IPv4-mapped IPv6 addresses in mixed dotted-quad form (e.g. "::ffff:192.0.2.128"), but the fromJSON() rule parser's IPv6 regexes excluded "." and capped the length at 39, so such rules were silently corrupted or dropped on a toJSON()/fromJSON() round-trip. Allow "." and raise the cap to 45 (the longest mixed form). Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
watilde
force-pushed
the
fix/blocklist-fromjson-ipv4-mapped-ipv6
branch
from
August 29, 2026 15:19
265bda4 to
f06e1c1
Compare
Member
Author
|
@jasnell Done! |
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64125 +/- ##
=======================================
Coverage 90.05% 90.06%
=======================================
Files 754 754
Lines 255727 255727
Branches 48320 48332 +12
=======================================
+ Hits 230300 230317 +17
+ Misses 16552 16543 -9
+ Partials 8875 8867 -8
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlockList.toJSON() serializes IPv4-mapped IPv6 addresses in mixed dotted-quad form (e.g. "::ffff:192.0.2.128"), but the fromJSON() rule parser's IPv6 regexes excluded "." and capped the length at 39, so such rules were silently corrupted or dropped on a toJSON()/fromJSON() round-trip. Allow "." and raise the cap to 45 (the longest mixed form).