Repository navigation
pad memory and CPU profiles with None to stabilize schema - #74
Merged
Merged
Conversation
NS_PER_UNIT and Selector.includes had no callers left, and the completion generator, path display and selector checks were helpers used once, so reading their call sites meant a jump for no reuse. The note on `host` sat under an unrelated constant in compare.py and now lives with SKEW_FIELDS, the tuple it explains.
The console column sizing test repeated one in test_runner.py, the slash-name and empty-run tests asserted behavior no code path can break on its own, and the plain .jsonl DuckDB case tested DuckDB's reader rather than anything the gzipped case leaves uncovered. They cost run time without guarding mew.
…ut a measurement DuckDB infers columns from the keys it sees, so a file no profiler wrote to had no memory or cpu_profile column, and a query naming one failed to bind instead of returning NULL. Padding with null, as skip already is, keeps the columns in every file without implying a measurement, where an empty object would infer a map that rejects arithmetic. Readers checking for a block now test for None rather than key presence.
Keeps the uv-lock hook on the uv release that wrote the lockfile, and picks up the current ty and docs toolchain releases so local checks match what CI resolves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies duckDB queries on JSON archives.