Skip to content

Update workflows for Snakemake v9.17.0 #39

Closed

Description

@victorlin

Snakemake version 9.17.0 includes a breaking change for our usage.

Specifically, snakemake/snakemake@ffb19e7 moved Wildcards from snakemake.io to snakemake.io.container. This breaks all imports that rely on the old location – shared/snakemake/config.smk and all 14 copies of it.

Possible solutions

Short term

  • Pin snakemake to <9.17.0 in managed runtimes (docker, conda)

Long term

  1. 🔴 Import from the new location.
    • This would need a try/except ImportError to be generally compatible across Snakemake versions.
  2. 🟢 Remove the import.

First noticed in nextstrain/conda-base#150 (comment).

Activity

  1. joverlee521 commented on Mar 26, 2026

    @joverlee521

    Yeah, agree with option 2.

  2. joverlee521 commented on Mar 31, 2026

    @joverlee521

    v9.18.0 (snakemake/snakemake@2ed2c23) moved Wildcards again from snakemake.io.containers to snakemake.iocontainers. Definitely going with option 2.

  3. victorlin commented on Apr 6, 2026

    @victorlin
    MemberAuthor

    @joverlee521 thanks for making the change in the shared repo.

    The next step is to update all 14 downstream copies. This is inherently tedious. Half of the tedium could be removed with automated PRs of git subrepo pull via a central GitHub Actions workflow. We would still manually review/merge the PRs just like dependabot and pre-commit PRs. Any thoughts on this idea?

  4. joverlee521 commented on Apr 7, 2026

    @joverlee521

    Oh yeah, I like the idea of a central GH Action workflow that creates automated PRs. Most of the time this would be an easy review & merge and only a small number of PRs would require additional fixes.

  5. joverlee521 commented on Apr 11, 2026

    @joverlee521

    Trying out the central GH Action workflow to update the vendored copies with nextstrain/shared@main...update-vendored. Test run failed with permission errors that I'll look into next week.

  6. joverlee521 commented on Apr 13, 2026

    @joverlee521

    Latest test run completed successfully and created PRs for all of the vendored repos. I'll clean up the GH workflow a little and make a PR.

  7. joverlee521 commented on Apr 21, 2026

    @joverlee521

    All relevant pathogen workflows have been updated to drop the snakemake.io.Wildcards import and I've linked them in the main issue description.

    I did not merge the following PRs because they will require more fixes but they have an older copy of the vendored subrepo, so they do not have the import and should not block this issue.

  8. added a commit that references this issue on Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions