Repository navigation
Give every shells case the suite's two-minute case timeout - #1710
Merged
Merged
Conversation
The first case runs on a dev server that has just booted, and under bun's 5-second default it timed out before the home page had compiled.
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt · project thread
tests/e2e/shells.test.ts"the public chrome is stage black while the page is not" timed out three times today: #1708 once, #1706 twice. Each time it was the first case of its CI slice, on a dev server that had just booted. It and eight other cases in the file ran under bun's 5-second default, which a cold home page can exceed.What changes
shells.test.tsgainsCASE_TIMEOUT_MS = 120_000, the value other suites use, and every case without its own timeout takes it. No assertion changes and no product code changes.Checks
shells.test.tspasses locally (15 pass, 0 fail).lint,check(7/7) andtypecheck:bunpass.Generated by Claude Code