Repository navigation
Resolve provider type profiles in the crucible workspace - #232
Merged
Merged
Conversation
Provider profiles are imported workspace-scoped, but CreateProvider sent an empty Provider.profile_workspace, which the gateway reads as platform scope. Every create failed with "provider profile ... was not found in the requested scope". Set it on all three create paths through one request builder; UpdateProvider keeps it empty. The scoped-literal guard matched the builder's return type, so it now skips matches preceded by `->`. Assisted-by: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crucible imports its provider profiles (
google-cloud, the broker profile,aws-s3) into thedefaultworkspace, butCreateProviderleftProvider.profile_workspaceempty, which the gateway treats as platform scope. Every provider create failed with "provider profile ... was not found in the requested scope".All three create paths now go through one request builder that sets
profile_workspace;UpdateProviderstill sends it empty. The scoped-literal test guard learned to skip return types, since the builder's signature tripped it.Changelog: Fixed: Sandboxed turns can create OpenShell providers again on gateways that resolve provider profiles by workspace.