findNvim: support finding nvim in Windows WSL #430

Activity

1. justinmk

   added

   enhancementfeaturefeature

   on Oct 19, 2024
2. justinmk

   changed the title [-]Support finding nvim in the WSL[/-] [+]findNvim: support finding nvim in Windows WSL[/+] on Oct 19, 2024
3. justinmk commented on Oct 19, 2024

   

   justinmk

   on Oct 19, 2024

   Last edited by justinmk

   Member

   More actions

   Ok, I see that this blocks vscode-neovim/vscode-neovim#2287 .

   https://github.com/vscode-neovim/vscode-neovim/blob/c3e8387a9e9f923ec39c28af6cb8985ca431e438/src/main_controller.ts#L181-L186

   if (config.useWsl) {
       args.push("C:\\Windows\\system32\\wsl.exe");
       if (config.wslDistribution.length) {
           args.push("-d", config.wslDistribution);
       }
   }

   I think that findNvim can support this without much complexity, by changing paths: string[] to cmds: string[][], so that consumers can pass a command like:

   findNvim(..., {
    paths: [
      ['C:\\Windows\\system32\\wsl.exe', '-d', ..., 'nvim'],
    ],
   })

   Perhaps in the future, findNvim could be more clever and do this internally. But meanwhile this is a simple change.
4. gjf7 commented on Oct 21, 2024

   

   gjf7

   on Oct 21, 2024

   More actions

   Should we search wsl's $PATH?
5. justinmk commented on Oct 21, 2024

   

   justinmk

   on Oct 21, 2024

   Member

   More actions

   Should we search wsl's $PATH?

   We could try that in the future, but I think just changing the current paths: string[] to a cmds: string[][] solve the main problem for now.
6. gjf7 commented on Oct 21, 2024

   

   gjf7

   on Oct 21, 2024

   More actions

   I'm not sure I follow. What should findNvim actually return in this case? The full WSL command, or just the nvim path?
7. justinmk commented on Oct 21, 2024

   

   justinmk

   on Oct 21, 2024

   Member

   More actions

   The missing piece is that consumers like vscode-neovim/vscode-neovim#2287 can't send a full command which represents "nvim". It can only send a location (arg0) or directory.

   node-client doesn't need to know about WSL, it just needs to run what the consumer gives it. Currently the consumer can only send arg0, but we can fix that by allowing consumers to send [arg0, arg1, ...].

   👍React with 👍1Reacted by Sam Guo
8. justinmk commented on Oct 21, 2024

   

   justinmk

   on Oct 21, 2024

   Last edited by justinmk

   Member

   More actions

   I have a PR that I'll post in a minute. #432
9. gjf7 commented on Oct 21, 2024

   

   gjf7

   on Oct 21, 2024

   More actions

   Ah, I see.
10. justinmk

    closed this as completedin #432on Sep 11, 2026